opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

[receiver/kubeletstats] fix use network io as network errors bug

Open tianlin opened this issue 1 year ago • 5 comments

Description: <Describe what has changed.>

fix bug: internal/network.go use network io as network errors Link to tracking Issue: <Issue number if applicable> https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/14318 Testing: <Describe what testing was performed and which tests were added.> UT Documentation: <Describe the documentation added.>

tianlin avatar Sep 20 '22 04:09 tianlin

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: tianlin (59eb9e2c0df21f7a6739a26585332bcd3190462e)

@tianlin please sign the CLA.

This change is applied to kubelet reciever, but the issue is submitted for hostmetrics receiver. Please update the PR or crete another relevant issue

dmitryax avatar Sep 20 '22 05:09 dmitryax

@tianlin please sign the CLA.

This change is applied to kubelet reciever, but the issue is submitted for hostmetrics receiver. Please update the PR or crete another relevant issue

Done

tianlin avatar Sep 20 '22 05:09 tianlin

Please address the ask in the second paragraph

dmitryax avatar Sep 20 '22 05:09 dmitryax

Please address the ask in the second paragraph

Do you mean add changelog file under unrelease dir?

tianlin avatar Sep 20 '22 05:09 tianlin

This PR was marked stale due to lack of activity. It will be closed in 14 days.

github-actions[bot] avatar Oct 05 '22 05:10 github-actions[bot]

Please address the ask in the second paragraph

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@dmitryax , can you review this PR please?

tianlin avatar Oct 05 '22 10:10 tianlin

I was able to reproduce the bug and validate the fix. Thank you @tianlin!

dmitryax avatar Oct 08 '22 06:10 dmitryax