opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

[receiver/fluentforward] Add case to handle uint64 timestamp

Open bhogayatakb opened this issue 2 years ago • 8 comments

Link to tracking Issue: https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/11435

bhogayatakb avatar Sep 05 '22 10:09 bhogayatakb

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: bhogayatakb / name: Keval Bhogayata (78a501305a2b82eb860f1ecc31aebc379dc0232c)

linux-foundation-easycla[bot] avatar Sep 05 '22 10:09 linux-foundation-easycla[bot]

Lint errors, please fix

bogdandrutu avatar Sep 07 '22 05:09 bogdandrutu

@bogdandrutu Linting applied & Commit Ammended

bhogayatakb avatar Sep 07 '22 16:09 bhogayatakb

Let me know if there is anything I can do for the failing checks, @bogdandrutu @dmitryax

bhogayatakb avatar Sep 08 '22 12:09 bhogayatakb

@bhogayatakb can you please add a changelog entry and a test case?

dmitryax avatar Sep 13 '22 01:09 dmitryax

There was a testcase expecting uint to be an invalid type. As we are considering uint as a valid type for timestamp - this testcase should no longer be relevant, right ? [Refer the file changes - receiver/fluentforwardreceiver/conversion_test.go]

bhogayatakb avatar Sep 14 '22 09:09 bhogayatakb

@dmitryax added changelog entry and made changes in test cases, there is a failing check regarding integration test for rabbitmq, should I be making any changes to pass that test ?

bhogayatakb avatar Sep 15 '22 04:09 bhogayatakb

@dmitryax @bogdandrutu checks passed, is it good to go ?

bhogayatakb avatar Sep 20 '22 12:09 bhogayatakb