opentelemetry-android icon indicating copy to clipboard operation
opentelemetry-android copied to clipboard

Make publish-conventions more strongly typed

Open breedx-splk opened this issue 1 year ago • 3 comments

In this PR comment: https://github.com/open-telemetry/opentelemetry-android/pull/272/files#r1521368807

It was noted that the publishing could have been broken due to the project restructuring. We could probably benefit from changing the code in the publish conventions to be more explicit in order to prevent breaks like this in the future.

breedx-splk avatar Mar 12 '24 17:03 breedx-splk

I think it's not needed for v1 since it is not a behavior or API surface breakage.

marandaneto avatar Aug 14 '24 08:08 marandaneto

I think it's not needed for v1 since it is not a behavior or API surface breakage.

True, making them strongly typed can wait. I think I marked this as required because I was also thinking about defining what the instrumentation URIs format should look like, like io.opentelemetry.android.instrumentation:[project-name] or io.opentelemetry.android:instrumentation-[project-name]. It's probably better to create a new issue that's focused more on that part instead.

LikeTheSalad avatar Aug 14 '24 09:08 LikeTheSalad

I've created this issue to discuss it: https://github.com/open-telemetry/opentelemetry-android/issues/533

LikeTheSalad avatar Aug 14 '24 09:08 LikeTheSalad