opamp-spec icon indicating copy to clipboard operation
opamp-spec copied to clipboard

Published 20 hours ago • verified publisher icon open-telemetry

Add message about available components to AgentDetails

Open BinaryFissionGames opened this issue 1 year ago • 4 comments

This PR adds a new ComponentDetails type that allows agents to communicate metadata relating to the components available in the agent.

BinaryFissionGames avatar Aug 26 '24 13:08 BinaryFissionGames

@andykellr @tigrannajaryan Here's a rough draft of ComponentDetails, when you get a second to take a look.

BinaryFissionGames avatar Aug 26 '24 14:08 BinaryFissionGames

@tigrannajaryan friendly bump on this

BinaryFissionGames avatar Sep 06 '24 15:09 BinaryFissionGames

@tigrannajaryan friendly bump on this

Sorry for the delay. Reviewed.

tigrannajaryan avatar Sep 06 '24 15:09 tigrannajaryan

@BinaryFissionGames please ping me once this is updated to reflect our last discussion in https://github.com/open-telemetry/opamp-spec/issues/198

tigrannajaryan avatar Oct 08 '24 13:10 tigrannajaryan

Looks like a link is broken unrelated to the changes in this PR, but this should be good for another look.

BinaryFissionGames avatar Oct 24 '24 20:10 BinaryFissionGames

@andykellr or @dpaasman00 will you take over this PR to make the final fixes before merging?

tigrannajaryan avatar Oct 30 '24 22:10 tigrannajaryan

@andykellr or @dpaasman00 will you take over this PR to make the final fixes before merging?

Yes, I just pushed changes based on your feedback. It should be ready.

andykellr avatar Oct 31 '24 02:10 andykellr