opamp-spec icon indicating copy to clipboard operation
opamp-spec copied to clipboard

Separating the notions of Agent and Client

Open PeterF778 opened this issue 1 year ago • 6 comments

Separating the previous notion of Agent into Agent (as a managed entity) and Client (as an endpoint of OpAMP).

PeterF778 avatar Aug 23 '22 23:08 PeterF778

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: PeterF778 / name: Peter Findeisen (0d1d7b0aef0feaeb1c4da9e2258526889092126c)

Thanks @tigrannajaryan for reviewing. I tried to be careful with the changes, but it is a long document, and I might have missed some places. Yes, I looked carefully at the Packages section, and I thought all was good there. I'll have a small update soon.

PeterF778 avatar Aug 24 '22 19:08 PeterF778

Thank you for this :+1: I recently found myself stumbling over words when explaining how OpAMP works with/within the OT Agent :sweat_smile:

portertech avatar Aug 29 '22 18:08 portertech

Thank you for this 👍 I recently found myself stumbling over words when explaining how OpAMP works with/within the OT Agent 😅

@portertech do you think the changes introduced by this PR make it clearer?

tigrannajaryan avatar Aug 29 '22 21:08 tigrannajaryan

@andykellr @portertech I wonder what you guys think about this change. As the author of the current text I am probably biased towards the usage of "Agent" everywhere, so I may not be the best person to tell if this change makes the spec more clear (I think it definitely does in some places, but I am worried that overall it may result in some confusion because of using 2 different concepts). It would be great to know your opinion.

tigrannajaryan avatar Sep 06 '22 14:09 tigrannajaryan

Thank you @andykellr for the review. I agree with yours and @tigrannajaryan suggestions. I'll make the corrections next week.

PeterF778 avatar Sep 17 '22 00:09 PeterF778

@andykellr I will keep this open for you to also review.

tigrannajaryan avatar Sep 20 '22 21:09 tigrannajaryan

Merged. Thanks @PeterF778 !

tigrannajaryan avatar Sep 22 '22 17:09 tigrannajaryan