opamp-go icon indicating copy to clipboard operation
opamp-go copied to clipboard

Demo: Feat/connection settings status

Open michel-laterman opened this issue 6 months ago • 1 comments

Add support to automatically send connection settings status from the client to the server. When a client receives a message with offered connection settings it will immediately send a message stating that it is applying the settings. If the offered connection settings contain OpAMP settings the success/failure message will automatically be communicted. For other connection types the developer will need to call SetConnectionStatus within the OnMessage callback hook.

  • Relates: https://github.com/open-telemetry/opamp-spec/pull/220

michel-laterman avatar May 27 '25 22:05 michel-laterman

Codecov Report

:x: Patch coverage is 40.14599% with 82 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 78.08%. Comparing base (3521293) to head (2e48e12). :warning: Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
client/internal/receivedprocessor.go 28.31% 77 Missing and 4 partials :warning:
client/types/callbacks.go 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #390      +/-   ##
==========================================
- Coverage   80.10%   78.08%   -2.02%     
==========================================
  Files          27       27              
  Lines        2578     2715     +137     
==========================================
+ Hits         2065     2120      +55     
- Misses        395      472      +77     
- Partials      118      123       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 27 '25 22:05 codecov[bot]

The PR is doing mostly the right things. I left some comments.

Also need to resolve the conflicts.

tigrannajaryan avatar Jun 29 '25 21:06 tigrannajaryan

@tigrannajaryan can you please re-review?

michel-laterman avatar Aug 01 '25 16:08 michel-laterman

This looks good to me.

@andykellr I would like you to also take a look and see if you can confirm this doesn't break anything in your own code that uses opamp-go.

tigrannajaryan avatar Aug 05 '25 18:08 tigrannajaryan

This looks good to me.

@andykellr I would like you to also take a look and see if you can confirm this doesn't break anything in your own code that uses opamp-go.

Working well for us.

andykellr avatar Aug 06 '25 15:08 andykellr

@tigrannajaryan I can merge and release if you think it is ready.

andykellr avatar Aug 11 '25 19:08 andykellr

@andykellr sounds good. Please also update the CHANGELOG for opamp-spec v0.13 release.

tigrannajaryan avatar Aug 11 '25 21:08 tigrannajaryan