community icon indicating copy to clipboard operation
community copied to clipboard

Create new repository for OTel Prometheus Sidecar

Open jmacd opened this issue 3 years ago • 18 comments

I would like to create a new Github repository to house a Prometheus sidecar for exporting data from a Prometheus server to an OTLP endpoint. This tool helps OpenTelemetry users migrate to an OpenTelemetry-based system while continuing to run their Prometheus setup.

The code for this new repository resides here: https://github.com/lightstep/opentelemetry-prometheus-sidecar. See the README for a description of this software.

This will be a community owned part of the OpenTelemetry metrics ecosystem. I propose the name open-telemetry/prometheus-sidecar.

jmacd avatar Nov 17 '20 19:11 jmacd

I created https://github.com/open-telemetry/prometheus-sidecar

jmacd avatar Nov 18 '20 20:11 jmacd

The repo does not include change to use otlp.

bogdandrutu avatar Nov 20 '20 14:11 bogdandrutu

I made the repo private while I migrate commits. I've frozen the Lightstep repo and will begin that soon.

jmacd avatar Nov 20 '20 17:11 jmacd

I made the repo private while I migrate commits.

we need to make sure that all commits are under CNCF CLA. The direct migration of commits is discourged.

SergeyKanzhelev avatar Nov 20 '20 18:11 SergeyKanzhelev

I believe you can merge commits via the merge PR under your name with the signed CLA

SergeyKanzhelev avatar Nov 20 '20 18:11 SergeyKanzhelev

Thanks for pointing this out. I will be merging only my commits, however this raises a question, I suppose, about the other collaborators with existing commits reflected in the history. Is there a problem with forked code, generally, for OTel w.r.t. the CNCF?

jmacd avatar Nov 20 '20 21:11 jmacd

I imagine that because this is Google-owned source code, you could help if there is a problem @SergeyKanzhelev. I hope this is something Stackdriver will endorse.

jmacd avatar Nov 20 '20 21:11 jmacd

not a layer..

My understanding is that it is enough that somebody who "owns" code merged changes under CLA. Not sure what is the ownership of code in lightstep repo.

If something needed from me, happy to help or involve the right people from Google.

SergeyKanzhelev avatar Nov 20 '20 22:11 SergeyKanzhelev

I cloned the code in the current http://github.com/open-telemetry/prometheus-sidecar from https://github.com/Stackdriver/stackdriver-prometheus-sidecar, which is owned by Google I presume. The rest of the changes are mine, and I imagine that both Google and Lightstep support this, but the authors of the 199 existing commits are past/present Google employees--do we need to do anything to "legally" clone these commits into an OTel repo?

jmacd avatar Nov 20 '20 22:11 jmacd

@mtwo do you know what team owns it?

SergeyKanzhelev avatar Nov 20 '20 23:11 SergeyKanzhelev

It seems that @mtwo is out of office till Dec 3rd. And we will not have GC meeting for another week. @jmacd how soon do you need this? Can it wait for another week?

SergeyKanzhelev avatar Nov 20 '20 23:11 SergeyKanzhelev

Sergey, I think that the original code was authored by Joe’s team


From: Sergey Kanzhelev [email protected] Sent: Friday, November 20, 2020 5:53:35 PM To: open-telemetry/community [email protected] Cc: Morgan McLean [email protected]; Mention [email protected] Subject: Re: [open-telemetry/community] Create new repository for OTel Prometheus Sidecar (#575)

It seems that @mtwohttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmtwo&data=04%7C01%7C%7Cf6f13a6787f541a0a5aa08d88daf7ef6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637415132165811619%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=sAIq2fyXFC%2Bda0E27eR9I%2BJbrf4VK4X%2FB5fsx2tl2tc%3D&reserved=0 is out of office till Dec 3rd. And we will not have GC meeting for another week. @jmacdhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fjmacd&data=04%7C01%7C%7Cf6f13a6787f541a0a5aa08d88daf7ef6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637415132165821613%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=0XKbhi5ya9FHecJDhX%2FYvOS4XqbFTjtp404GWQwgTCw%3D&reserved=0 how soon do you need this? Can it wait for another week?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fopen-telemetry%2Fcommunity%2Fissues%2F575%23issuecomment-731465610&data=04%7C01%7C%7Cf6f13a6787f541a0a5aa08d88daf7ef6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637415132165821613%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vEBo1QzuZSMmTzSWVIKd6Yyr62JcdxvLB9DjJLcs8M4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAIXLK7HMUXG2R5RVFH34U3SQ36P7ANCNFSM4TZAPP7A&data=04%7C01%7C%7Cf6f13a6787f541a0a5aa08d88daf7ef6%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637415132165831606%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=9aAYb2dAIIAeCPbEAKqeLfpbJXafh1GKcbdhWRDQSI8%3D&reserved=0.

mtwo avatar Nov 21 '20 00:11 mtwo

This is not urgent.

jmacd avatar Nov 21 '20 01:11 jmacd

Thanks @SergeyKanzhelev and @mtwo.

jmacd avatar Nov 21 '20 01:11 jmacd

@SergeyKanzhelev I'd like to renew my request for Google to formally donate the Stackdriver Prometheus Sidecar commits so I can migrate the OTel variation to recognize those commits.

jmacd avatar Jan 21 '21 22:01 jmacd

Funny enough, my meeting with OSS team got cancelled tonight, but they promised to come back to me tomorrow morning.

SergeyKanzhelev avatar Jan 21 '21 22:01 SergeyKanzhelev

ok, got a reply. I just need to sign off on PR brining the code. Please go ahead!

SergeyKanzhelev avatar Jan 22 '21 20:01 SergeyKanzhelev

Wanted to check in on this, is there an update on getting things migrated to https://github.com/open-telemetry/prometheus-sidecar? Thanks!

BrianChristie avatar Aug 17 '21 08:08 BrianChristie

@jmacd is this still an open issue? thx!

trask avatar Jan 12 '23 17:01 trask

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

github-actions[bot] avatar Jan 19 '23 18:01 github-actions[bot]

The OTC Prometheus receiver has effectively replaced the need for this project by now.

jmacd avatar Jan 19 '23 18:01 jmacd