community icon indicating copy to clipboard operation
community copied to clipboard

REQUEST: Repository maintenance on opentelemetry-collector-releases

Open mowies opened this issue 5 months ago • 8 comments

Affected Repository

https://github.com/open-telemetry/opentelemetry-collector-releases

Requested changes

I'd like to request a github token or github app that is allowed to push tags that also trigger pipeline runs. If possible, I think that should be the otel bot user or otel bot github app.

Purpose

The purpose of the token is to push nightly tags on a scheduled basis. Those nightly tags should trigger the release pipelines to release a nightly release. (implementation PR)

Expected Duration

permanently

Repository Maintainers

  • @open-telemetry/collector-maintainers
  • @open-telemetry/collector-contrib-maintainers

mowies avatar Jul 24 '25 07:07 mowies

I support this

mx-psi avatar Jul 24 '25 10:07 mx-psi

I think it's all set now

      - uses: actions/create-github-app-token@df432ceedc7162793a195dd1713ff69aefc7379e # v2.0.6
        id: otelbot-token
        with:
          app-id: ${{ vars.OTELBOT_COLLECTOR_RELEASES_APP_ID }}
          private-key: ${{ secrets.OTELBOT_COLLECTOR_RELEASES_PRIVATE_KEY }}

and then use ${{ steps.otelbot-token.outputs.token }} later on

trask avatar Jul 28 '25 16:07 trask

thanks!

i added the code to https://github.com/open-telemetry/opentelemetry-collector-releases/pull/1016 in https://github.com/open-telemetry/opentelemetry-collector-releases/pull/1016/commits/a7c1cb1a8ca3396a9897299ad525c531143e9528 we'll probably only see if it works, when the PR is merged

mowies avatar Jul 29 '25 12:07 mowies

seems like we had some issues with this, where the bot didn't have access to push changes to the releases repo 🤔 https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/16916623152/job/47932017655

i'm not sure if i did some configuration error or if some permissions are not correct here... this is where the new token is used: https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/.github/workflows/update-version.yaml

mowies avatar Aug 13 '25 13:08 mowies

Ahh I used vars.OTELBOT_APP_ID and not vars.OTELBOT_COLLECTOR_RELEASES_APP_ID to get the token. I think that must have been the mistake. And it didn't break because that variable is also defined and used elsewhere 🤦🏼

mowies avatar Aug 13 '25 14:08 mowies

Using the correct app ID and private key worked now to push changes, but the PR is blocked because EasyCLA is not happy. Anything specific that needs to be done to allow the bot @trask or should we just use the otelbot git username and email and nothing special for the releases repo?

mowies avatar Aug 13 '25 14:08 mowies

ah, so in Java repo I just used otelbot for the committer, even when using OTELBOT_JAVA_CONTRIB_PRIVATE_KEY

https://github.com/open-telemetry/opentelemetry-java-contrib/blob/ea4b55602dee49fe4885778c82f5f0d40e924a5c/.github/workflows/auto-spotless-apply.yml#L35-L55

the other option is to open an EasyCLA Jira ticket and ask them to add the otelbot collector releases app to the allowlist, they are usually pretty responsive for these requests

trask avatar Aug 13 '25 17:08 trask

ok so then i'll just revert to the default git user/email settings if that works :) looks better anyways if its the otelbot and not the collector-releases-otelbot doing things 😄

mowies avatar Aug 14 '25 07:08 mowies