REQUEST: Repository maintenance on open-telemetry/opentelemetry-ebpf-instrumentation

[marctc]

Affected Repository

https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation

Requested changes

After this comment we decide to balance out the numbers of Grafana maintainers to only two. However I will be active in this project in the upcoming months so I'd be great to have merge rights. I'm currently doing a task of porting change from Beyla to this project and it's a bit unpractical not having merge rights.

thanks!

Repository Maintainers

@MrAlias @grcevski @mariomac

[mariomac]

Even if Marc couldn't become a maintainer I wonder if he could at least grant him merge rights. He is actively working on porting some improvements from Beyla to the opentelemetry-ebf-instrument repository and has a growing list of PRs that need to be rebased/merged: https://github.com/open-telemetry/opentelemetry-ebpf-instrumentation/pulls/marctc

[marctc]

Here's the whole list for now: https://github.com/grafana/opentelemetry-ebpf-instrumentation/branches/active?page=1

[trask]

@mariomac @marctc is the issue due to "Require branches to be up to date before merging"?

If so, it's ok to remove that setting (see https://github.com/open-telemetry/community/blob/main/docs/how-to-configure-new-repository.md#branch-protection-rule-main).

Or, if you want to keep that level of protection, but remove the burden of rebasing before merging, you can set up a merge queue.

[mariomac]

Hi @trask! Definitely removing the Require branches to be up to date before merging setting would help 💯 . Since we are currently in "development/unstable" status, I think we can afford the small risk of merging without having to rebase first.

Anyway, if there is a possibility that Marc gets merge rights would help unblocking him when I'm not available, as the rest of maintainers are in another time zone.

[trask]

Definitely removing the Require branches to be up to date before merging setting would help 💯

done!

can you see if this is enough to unblock work, since otherwise it requires an exception to our current process?

[MrAlias]

@marctc @mariomac: Traditionally in OTel merge permissions are only provided to maintainers of the repository. If @marctc is looking to be moved to an approver role he would lose that access.

Is there a concern that the remaining maintainers won't be able to merge the submitted PRs?

[marctc]

If @marctc is looking to be moved to an approver role he would lose that access.

I'm already an approver. Why I would lose the access to approver role?

Is there a concern that the remaining maintainers won't be able to merge the submitted PRs?

I'm sorry but I don't understand what do you mean.

[marctc]

Maybe i was not clear in my message. but I initallize was maintainer and then i was moved to be approver.

[MrAlias]

Gotcha.

Do you currently have merge permissions? Or, is this issue intended to add merge permissions to your user?

[marctc]

No, I don't. I would be great to have them! Thanks!

[MrAlias]

So merge permissions are only given to maintainers. That is a large part of the responsibility of that role. I don't see reason to make an exception to that policy here. Right, @trask?

[marctc]

Makes sense. Can I have maintainership then? cheers

[trask]

@marctc @mariomac can you add more details about the problem we're trying to solve here? thanks!

[github-actions[bot]]

This has been automatically marked as stale because it has been marked as needing author feedback and has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.