community icon indicating copy to clipboard operation
community copied to clipboard

REQUEST: Extra packages on baremetal runners

Open scottgerring opened this issue 8 months ago • 12 comments

Affected Repository

https://github.com/open-telemetry/opentelemetry-rust

Requested Changes

Over in otel-rust, we'd like to move our performance benchmarks for main onto the baremetal runners. In #2616 , @trask has given us access, but we've discovered that we can't use them just yet, as we've discovered a couple system deps we need - so far, unzip and build-essential (but more may pop up when we get further in the build process).

Is it in principal possible to request additional packages be installed to these ubuntu workers? If it is, I can run the build through in a minimal docker image, work out what packages we need in totality, and then report back.

Alternatives Considered

Wrapping things up in docker so we can control our own destinies, but 1/ docker is also not installed and 2/ this will make it harder to structure and still benefit from github actions for performance testing.

scottgerring avatar Apr 24 '25 14:04 scottgerring

Not sure what label to apply here, since this is Github related so 'project-infra' does not apply

mx-psi avatar Apr 28 '25 09:04 mx-psi

@scottgerring is it an option to install the system deps as part of your CI?

cc @jpkrohling @open-telemetry/technical-committee as admins for the bare metal runners.

also cc @open-telemetry/go-maintainers, is this a problem you've run across?

trask avatar Apr 28 '25 19:04 trask

@scottgerring is it an option to install the system deps as part of your CI?

I don't have sudo access, and am to be honest glad not to have it :D

scottgerring avatar Apr 29 '25 10:04 scottgerring

@open-telemetry/go-maintainers, is this a problem you've run across?

I am not aware of any problems on our side. I also think it is fine to add unzip, build-essential, and anything that Rust needs.

Would be good to double-check if all workflows are still working fine after installing new tools: https://github.com/search?q=org%3Aopen-telemetry+%22runs-on%3A+self-hosted%22+path%3A%2F%5E%5C.github%5C%2Fworkflows%5C%2F%2F&type=code

pellared avatar Apr 30 '25 05:04 pellared

@jpkrohling @open-telemetry/technical-committee as admins for the bare metal runners:

can you add these tools?

trask avatar Apr 30 '25 14:04 trask

Bump! @jpkrohling in case this has fallen off your radar!

scottgerring avatar May 20 '25 13:05 scottgerring

fyi I ran across this recently: https://deploy.equinix.com/blog/sunsetting-equinix-metal/

trask avatar May 20 '25 14:05 trask

fyi I ran across this recently: https://deploy.equinix.com/blog/sunsetting-equinix-metal/

Well, that's a pity. From OTel's perspective, I would imagine the project would like to retain this feature (the need for perf benchmarking won't go away) - so perhaps there's a parallel need to look at other providers here?

scottgerring avatar May 21 '25 06:05 scottgerring

It did fall off my radar, sorry :-( I do have access to Equinix, if still needed, let me know!

jpkrohling avatar May 21 '25 15:05 jpkrohling

@scottgerring it sounds like we can get dedicated hosts in Oracle Cloud (https://github.com/open-telemetry/community/blob/main/assets.md#oracle-cloud-account).

I've added this to tomorrow's Project Infrastructure SIG agenda to see how we can make that happen.

trask avatar May 21 '25 16:05 trask

Hey @trask that sounds great! Would be happy to lend a hand here in terms of setup etc. insofar as that is useful. Let me know

scottgerring avatar May 27 '25 06:05 scottgerring

Working on setting up the Oracle bare metal runner in #2801

trask avatar Jun 06 '25 15:06 trask

This is done now via #2801

trask avatar Jul 07 '25 02:07 trask