community icon indicating copy to clipboard operation
community copied to clipboard

Proposal: Use harden-runner in jobs using OPENTELEMETRYBOT_GITHUB_TOKEN

Open pellared opened this issue 2 years ago • 6 comments

We can consider using https://github.com/step-security/harden-runner in places where OPENTELEMETRYBOT_GITHUB_TOKEN is used.

Proposal:

  1. Try using in one repository (e.g. in https://github.com/open-telemetry/opentelemetry-go/blob/main/.github/workflows/create-dependabot-pr.yml)
  2. Propose a PR for https://github.com/open-telemetry/community/blob/main/assets.md#opentelemetry-bot to recommend using https://github.com/step-security/harden-runner
  3. Create issues for repos which are using OPENTELEMETRYBOT_GITHUB_TOKEN so that they add https://github.com/step-security/harden-runner

pellared avatar Jun 22 '23 06:06 pellared

CC @trask

pellared avatar Jun 22 '23 06:06 pellared

We can consider using https://github.com/step-security/harden-runner in places where OPENTELEMETRYBOT_GITHUB_TOKEN is used.

the OPENTELEMETRYBOT_GITHUB_TOKEN fine-grained PAT org secret will have very limited permissions once #1549 is implemented

do you mean specifically for the additional fine-grained PATs with write access to a single repo for those who want to grant write permission to @opentelemetrybot? (https://github.com/open-telemetry/community/issues/1503#issuecomment-1588193654)

trask avatar Jul 06 '23 00:07 trask

do you mean specifically for the additional fine-grained PATs with write access to a single repo for those who want to grant write permission to @opentelemetrybot?

Yup. However, it may be safer to use it everywhere where OPENTELEMETRYBOT_GITHUB_TOKEN is used as the permissions of the PAT may change and the contributor may not know what are the permissions.

pellared avatar Jul 13 '23 07:07 pellared

@pellared this fell through the cracks. Is it is still actual?

tigrannajaryan avatar Apr 19 '24 17:04 tigrannajaryan

@tigrannajaryan, yes it is. I think that the proposal should be reviewed by Security SIG.

pellared avatar May 15 '24 11:05 pellared

cc @open-telemetry/sig-security-maintainers

trask avatar May 15 '24 15:05 trask