open-telemetry
Add multiarch Docker images
Use Docker actions and metadata-action to build the image for linux/arm, linux/arm64, linux/amd64.
Right now it will use edge as tag for the latest commit on main instead of latest (that's also the default for the action). And latest for the latest tag.
That's what I've seen in all the projects I've used. Let me know if that works.
Supersedes:
- #116
- #73
- #99
Closes:
- Closes #115
- Closes https://github.com/open-telemetry/opentelemetry-proto-go/issues/77
The build is taking a really long time and GitHub kills it after 6 hours, maybe we could just add arm64 for now? I’m looking into cross compiling but it’s not that straightforward.
@lucacome do you plan to work on this? I tried building from your branch but the build failed for me. I think we can skip arm and add just arm64 for now.
yeah I can resume working on this @tigrannajaryan I was waiting for somebody to review it 🙂
@lucacome I think this needs a rebase to resolve conflicts and also because many of dockerfile dependency versions have been updated since the PR was first created.
I am happy to review it.
@lucacome thank you for updating the PR. Sorry for late reply, I missed the notification that the PR was updated.
I see that the build passes now, but I do not see anywhere in the output that it also builds the arm version. Can you help me understand?
@tigrannajaryan I've resumed working on this. I split the two builds into two different runners but the arm64 still takes 3.5 hours.
I'm looking into cross-compiling but it's not been very successful. Not sure if we still want to merge this in the meantime to start building for arm64. It shouldn't be too bad once everything is cached if there aren't too many changes.