jsoncpp
jsoncpp copied to clipboard
Make the build configuration under Bazel more correct.
- Expose
JSON_USE_EXCEPTIONandJSON_HAS_INT64as Bazel config flags with defaults that match the existing Bazel build. - Switch
//:jsoncppfrom usingcoptstodefinesforJSON_USE_EXCEPTIONandJSON_HAS_INT64so that rules that depend on it get the same config. - Make
src/test_lib_json/fuzz.cpprespectJSON_USE_EXCEPTION. #ifdefstuff that should only be used withJSON_USE_EXCEPTION.
Note:
See also https://github.com/open-source-parsers/jsoncpp/pull/1601
Testing:
This builds with all 4 combinations:
for i in true false ; do
for e in true false ; do
bazel build --@//:use_exception=${e} --@//:has_int64=${i} ...
done
done
Poke?
Poke?
Any chance of getting a review of this?