libcosim icon indicating copy to clipboard operation
libcosim copied to clipboard

Don't crash if FMUs log with category=NULL

Open kyllingstad opened this issue 2 months ago • 5 comments

This fixes #796.

We don't have any straightforward way to test this right now, since our test FMUs aren't easily modifiable. Perhaps @SSkjong, who discovered the issue, can test with the FMU that triggered it?

kyllingstad avatar Oct 21 '25 08:10 kyllingstad

Ser bra ut dette.

SSkjong avatar Oct 21 '25 09:10 SSkjong

I don't understand the build failures. I don't think they are related to this particular PR, and I can't reproduce them locally even using the same Conan version as that used in CI.

kyllingstad avatar Oct 21 '25 09:10 kyllingstad

Tested locally with an fmiCpp FMU provided by @SSkjong and confirmed that it works:

image

kyllingstad avatar Oct 21 '25 10:10 kyllingstad

@davidhjp01, @restenb, do any of you have any idea what is going on in the Linux CI builds here?

kyllingstad avatar Nov 06 '25 12:11 kyllingstad

@davidhjp01, @restenb, do any of you have any idea what is going on in the Linux CI builds here?

I also had the same issue, try this changes: https://github.com/open-simulation-platform/libcosim/commit/62cd2ecc3c75299409f3dd4acc3a80300c333fc4

davidhjp01 avatar Nov 06 '25 13:11 davidhjp01