repo-query icon indicating copy to clipboard operation
repo-query copied to clipboard

Feature: find a way to remove `native-tls` from our dependency chain

Open jpmcb opened this issue 1 year ago • 0 comments

Type of feature

🍕 Feature

Current behavior

Ideally we wouldn't be consuming openssl through the native-tls chain of dependencies:

❯ cargo tree -i native-tls
native-tls v0.2.11
├── hyper-tls v0.5.0
│   └── reqwest v0.11.18
│       ├── cached-path v0.6.1
│       │   └── tokenizers v0.13.3
│       │       └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
│       ├── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
│       ├── openai-api-rs v0.1.11
│       │   └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
│       ├── qdrant-client v1.3.0
│       │   └── open-sauced-repo-query v0.1.0 (/Users/jpmcb/workspace/opensauced/repo-query)
│       └── tokenizers v0.13.3 (*)
├── reqwest v0.11.18 (*)
└── tokio-native-tls v0.3.1
    ├── hyper-tls v0.5.0 (*)
    └── reqwest v0.11.18 (*)

But it looks like a there are some upstream changes that would need to be made in order to flip them to using rustls (or at least enable a feature that can use rustls-tls instead of native-tls)

Suggested solution

We'd need to upstream some changes to those libraries that are deep in our rust dependencies.

And this shouldn't be a priority until we consider adding TLS for requests to the repo-query engine. More just noting this for myself and others to be aware of.

Additional context

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Contributing Docs

  • [X] I agree to follow this project's Contribution Docs

jpmcb avatar Aug 03 '23 16:08 jpmcb