hot icon indicating copy to clipboard operation
hot copied to clipboard

Remove tailwinds anti-pattern in Hero.tsx

Open bdougie opened this issue 1 year ago • 2 comments

Context is on the tracking issue - https://github.com/open-sauced/hot/issues/267

This issue only needs changes to this file.

bdougie avatar Aug 16 '22 23:08 bdougie

.take

AlexVCS avatar Sep 06 '22 21:09 AlexVCS

Thanks for taking this on! If you have not already, join the conversation in our Discord

github-actions[bot] avatar Sep 06 '22 21:09 github-actions[bot]

.take

teachjenntech avatar Oct 03 '22 16:10 teachjenntech

Thanks for taking this on! If you have not already, join the conversation in our Discord

github-actions[bot] avatar Oct 03 '22 16:10 github-actions[bot]

This is mostly completed on this open PR - https://github.com/open-sauced/hot/pull/337/files#diff-1cadf8397b7345b9f320a7c7e007a8bc697f2c9deec3085de9bd17e057ac0f0a

The only question was the use of rems was not ideal and I don't think I saw a response from @AlexVCS on why.

bdougie avatar Oct 03 '22 20:10 bdougie

My apologies @bdougie! I've changed the code to use Tailwind's default spacing scale instead of hardcoding rem values.

AlexVCS avatar Oct 03 '22 22:10 AlexVCS

:tada: This issue has been resolved in version 2.25.0-beta.8 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 04 '22 05:10 github-actions[bot]

:tada: This issue has been resolved in version 2.26.0-beta.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 05 '22 00:10 github-actions[bot]

:tada: This issue has been resolved in version 2.26.0-alpha.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 18 '22 21:10 github-actions[bot]

:tada: This issue has been resolved in version 2.26.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Oct 28 '22 22:10 github-actions[bot]