hot icon indicating copy to clipboard operation
hot copied to clipboard

Feature: Loading skeleton in Hero

Open NsdHSO opened this issue 1 year ago β€’ 5 comments

Type of feature

πŸ• Feature

Current behavior

If you search in the search box after one repo, we receive responses 1-2 seconds. I think we should display a skeleton

Suggested solution

     if (isLoading) {
    return (
      <div className="p-4 border rounded-2xl bg-white w-full space-y-1 relative">
       // Hint Array.from(Array(5)) || props count = {1,2,3....}
        <Skeleton
          enableAnimation
          count={1}
        />
      </div>
    );
  }

Additional context

issue: fix #297

PR: #296

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Contributing Docs

  • [X] I agree to follow this project's Contribution Docs

NsdHSO avatar Aug 08 '22 21:08 NsdHSO

not technically a good first issue since it is blocked by another PR. All Good First Issues should have clear solutions.

bdougie avatar Aug 08 '22 22:08 bdougie

.take

OgDev-01 avatar Aug 11 '22 23:08 OgDev-01

Thanks for taking this on! If you have not already, join the conversation in our Discord

github-actions[bot] avatar Aug 11 '22 23:08 github-actions[bot]

I'm thinking about making the hero card a separate reusable component, to stay organized... @bdougie what do u think about that?

OgDev-01 avatar Aug 12 '22 06:08 OgDev-01

Yes, good remarks, but you don't have this to do with this issue. See here, we get the answer after 1-2 seconds. image

NsdHSO avatar Aug 12 '22 07:08 NsdHSO

Closing this for now. however, we do need a skeleton for RepoWrap instead. I will open that issue.

bdougie avatar Oct 04 '22 21:10 bdougie