hot
hot copied to clipboard
Feature: Remove tailwinds anti-pattern
Type of feature
π§βπ» Refactor
Current behavior
Through out the app we are using hard-coded px
<div className="mx-auto max-w-7xl px-[16px] mt-[40px]">
Suggested solution
We need to use the design system provided by Tailwind or provide variables.
<div className="mx-auto max-w-7xl px-2 mt-4">
Additional context
Please work on each file independently. Do not open a PR for all files, but one file per PR to avoid merge conflicts.
- [x] #314
- [ ] #315
- [x] #316
- [x] #317
- [x] #318
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Contributing Docs
- [X] I agree to follow this project's Contribution Docs
Fonts were switch in the PostList in this PR #242
Going to take this over.
@bdougie As, it's the changes for the whole project, what do you think about breaking these issues into separate issues and PR?
@bdougie As, it's the changes for the whole project, what do you about breaking these issues into separate issues and PR?
A lot of this is done in #269 - if you wait for that to get merged in this ticket doesn't need to be broken up into smaller pieces, just search and replace! π
@0-vortex what's the best thing I can do right now?
@0-vortex what's the best thing I can do right now?
You can start working on this from the beta
branch, #269 has been merged in! π π