hot icon indicating copy to clipboard operation
hot copied to clipboard

Feature: Remove tailwinds anti-pattern

Open bdougie opened this issue 1 year ago β€’ 6 comments

Type of feature

πŸ§‘β€πŸ’» Refactor

Current behavior

Through out the app we are using hard-coded px

 <div className="mx-auto max-w-7xl px-[16px] mt-[40px]">

Suggested solution

We need to use the design system provided by Tailwind or provide variables.

 <div className="mx-auto max-w-7xl px-2 mt-4">

Additional context

Please work on each file independently. Do not open a PR for all files, but one file per PR to avoid merge conflicts.

  • [x] #314
  • [ ] #315
  • [x] #316
  • [x] #317
  • [x] #318

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Contributing Docs

  • [X] I agree to follow this project's Contribution Docs

bdougie avatar Jul 30 '22 11:07 bdougie

Fonts were switch in the PostList in this PR #242

bdougie avatar Jul 30 '22 12:07 bdougie

Going to take this over.

shamimbinnur avatar Jul 30 '22 19:07 shamimbinnur

@bdougie As, it's the changes for the whole project, what do you think about breaking these issues into separate issues and PR?

shamimbinnur avatar Aug 02 '22 05:08 shamimbinnur

@bdougie As, it's the changes for the whole project, what do you about breaking these issues into separate issues and PR?

A lot of this is done in #269 - if you wait for that to get merged in this ticket doesn't need to be broken up into smaller pieces, just search and replace! πŸ•

0-vortex avatar Aug 02 '22 12:08 0-vortex

@0-vortex what's the best thing I can do right now?

shamimbinnur avatar Aug 02 '22 13:08 shamimbinnur

@0-vortex what's the best thing I can do right now?

You can start working on this from the beta branch, #269 has been merged in! πŸ• πŸš€

0-vortex avatar Aug 02 '22 22:08 0-vortex