app icon indicating copy to clipboard operation
app copied to clipboard

fix: Now you can't type more than 255 characters in the bio field of user settings

Open Pagla-Dasu opened this issue 1 year ago • 9 comments

Now, it Can't keep typing in the bio field of user settings after 255 characters. Changed the code in user-sttings-page.tsx

fix #2612

Description

This PR fixes the issue #2612 fixing the maximum character issue of 255 characters.

What type of PR is this? (check all applicable)

  • [ ] 🍕 Feature
  • [x] 🐛 Bug Fix
  • [ ] 📝 Documentation Update
  • [ ] 🎨 Style
  • [ ] 🧑‍💻 Code Refactor
  • [ ] 🔥 Performance Improvements
  • [ ] ✅ Test
  • [ ] 🤖 Build
  • [ ] 🔁 CI
  • [ ] 📦 Chore (Release)
  • [ ] ⏩ Revert

Related Tickets & Documents

Please use this format link issue numbers: Fixes #2612 https://github.com/open-sauced/app/issues/2612

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • [ ] 📜 README.md
  • [ ] 📓 docs.opensauced.pizza
  • [ ] 🍕 dev.to/opensauced
  • [ ] 📕 storybook
  • [x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Pagla-Dasu avatar Feb 07 '24 17:02 Pagla-Dasu

Deploy Preview for oss-insights ready!

Name Link
Latest commit fe29c717ecc16ef5960559e3870278fb1fa066f9
Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66aa2f19da3235000833dac5
Deploy Preview https://deploy-preview-2615--oss-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 07 '24 17:02 netlify[bot]

Deploy Preview for design-insights ready!

Name Link
Latest commit fe29c717ecc16ef5960559e3870278fb1fa066f9
Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66aa2f1999194a00080647a0
Deploy Preview https://deploy-preview-2615--design-insights.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 07 '24 17:02 netlify[bot]

@nickytonline you're welcome 👍🏼

Pagla-Dasu avatar Feb 07 '24 18:02 Pagla-Dasu

@nickytonline , Any update on the PR?

Pagla-Dasu avatar Feb 08 '24 09:02 Pagla-Dasu

There are failures because of linting/prettier.

./components/organisms/UserSettingsPage/user-settings-page.tsx
284:30  Error: Replace `·=·` with `=`  prettier/prettier
2[91](https://github.com/open-sauced/app/actions/runs/7821446623/job/21339420324?pr=2615#step:6:92):1  Error: Replace `+················{bio?.length}/255⏎+` with `················+·{bio?.length}/255·+{"·"}⏎·`  prettier/prettier

run npm lint -- --fix to fix that.

nickytonline avatar Feb 08 '24 13:02 nickytonline

@nickytonline , The prettier issue is fixed, you can now merge the code.

Pagla-Dasu avatar Feb 08 '24 16:02 Pagla-Dasu

@Pagla-Dasu how are things going here?

BekahHW avatar Apr 19 '24 19:04 BekahHW

@Pagla-Dasu how are things going here?

oh, I am so sorry @BekahHW, I missed your request for those changes. Will get that done asap.

Pagla-Dasu avatar Apr 19 '24 20:04 Pagla-Dasu

@nickytonline @BekahHW, do check the commit. The changes are made accordingly.

Pagla-Dasu avatar Apr 23 '24 08:04 Pagla-Dasu

cc @open-sauced/engineering let's have a look at this and clean up long standing PRs 🙏🏼

jpmcb avatar Jul 30 '24 15:07 jpmcb