examples icon indicating copy to clipboard operation
examples copied to clipboard

Updated all the files's req.env ==> req.variables.

Open 35C4n0r opened this issue 2 years ago • 5 comments

I've updated all the files in which req.env was being used previously to req.variables. I've also remove emojis from some of the files and comments. Signed-off-by: 35C4n0r [email protected]

35C4n0r avatar Oct 13 '22 12:10 35C4n0r

Hey there 👋 Thanks for the PR. I noticed you missed a few files in PHP:

  • object_detection
  • generate_giphy_gif
  • convert-phone-number-to-country-name

Please update those too, same thing, renaming from env to variables.

@Meldiron thanks for the review, i've made the changes.

35C4n0r avatar Oct 14 '22 09:10 35C4n0r

Hey there 👋 Thanks for the PR. I noticed you missed a few files in PHP:

* object_detection

* generate_giphy_gif

* convert-phone-number-to-country-name

I already have two PRs for updating the Giphy (https://github.com/open-runtimes/examples/pull/74) and Object Detection (https://github.com/open-runtimes/examples/pull/75) once. Also, shouldn't the docker runtimes also be updated to v2 as well?

thinkverse avatar Oct 14 '22 16:10 thinkverse

I already have two PRs for updating the Giphy (#74) and Object Detection (#75) once. Also, shouldn't the docker runtimes also be updated to v2 as well?

@thinkverse for updating docker runtimes to v2 we only need to change the commands provided in the READMEs, right?

35C4n0r avatar Oct 14 '22 16:10 35C4n0r

updating docker runtimes to v2 we only need to change the commands provided in the READMEs

That's my assumption yes, @Meldiron could confirm. Since it's the v2 image tags that use variables instead of env.

thinkverse avatar Oct 14 '22 16:10 thinkverse

@35C4n0r, yes please update the readmes except for the ones that would conflict with #74 and #75 🙏🏼

stnguyen90 avatar Nov 03 '22 19:11 stnguyen90

@stnguyen90 @Meldiron There was a conflict, which has now been resolved. Please review and merge this PR.

35C4n0r avatar Jan 19 '23 13:01 35C4n0r

Thanks for the amazing PR 😇 Merging the PR now 🥳

Meldiron avatar Jan 20 '23 14:01 Meldiron