generator icon indicating copy to clipboard operation
generator copied to clipboard

fix: 🐛 support gatsby path prefix

Open punkbit opened this issue 2 years ago • 2 comments

Why?

When setting the pathPrefix of gatsby-config.js to anything else then /, the landing page CTA button which links to /api-documentation fails. Thus, removed the slash to fallback gracefully to whichever path prefix is setup.

How?

  • Remove / from button href.

Demo?

👀 See bottom left corner, where the CTA URL has the missing pathPrefix, where in the main menu it has the pathPrefix.

https://github.com/open-rpc/generator/assets/236752/3a9fed7e-24cf-4a01-9905-f50b5d3132ac

punkbit avatar Aug 09 '23 15:08 punkbit

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '23 15:08 CLAassistant

@phyro @shanejonas @zcstarr any of you mind having a look here please?

punkbit avatar Aug 15 '23 10:08 punkbit

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.57%. Comparing base (2a6e119) to head (8186eba).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files           6        6           
  Lines         236      236           
  Branches       35       35           
=======================================
  Hits          235      235           
  Misses          1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 19:05 codecov[bot]