liboqs
liboqs copied to clipboard
open-quantum-safe
CPU extension detection for arm64 on NetBSD.
Looks good to me other than some style things. @SWilson4 Do we have a NetBSD CI setup to check that this works as expected? Do we currently sanity check CPU extensions in CI?
Nope, no NetBSD setup. It seems like something that would be nice to have to support ongoing work on porting liboqs to NetBSD. I believe that there is also no sanity checking of CPU extensions, though it might be hidden somewhere.
we need to get the NetBSD runner up. I will get back to this. I got delayed a bit. It has landed in NetBSD pkgsrc however: http://cvsweb.netbsd.org/bsdweb.cgi/~checkout~/pkgsrc/security/liboqs/patches/patch-common.c?rev=1.1;content-type=text%2Fx-csrc.
Closing after 2 more months without updates. Please re-open to re-activate @loganaden if you have time again.
FWIW, I'd still like to see NetBSD supported officially. For pkgsrc, I pulled in this diff, and have been running liboqs / oqs-provider for months now. Happy to test other changes if needed.
FWIW, I'd still like to see NetBSD supported officially. For pkgsrc, I pulled in this diff, and have been running liboqs / oqs-provider for months now. Happy to test other changes if needed.
We're happy to accept an updated PR.
What needs to be updated in this PR? As best as I can tell the diff applies cleanly on the latest source, so can't this be merged as is?
What needs to be updated in this PR? As best as I can tell the diff applies cleanly on the latest source, so can't this be merged as is?
We had hoped to be able to have some CI on NetBSD. Do you know if there is a convenient way to do that within the Github Actions context?
I'm afraid I don't, but @loganaden mentioned that they were looking into setting something up?