Buildroot 2023.02 kernel 5.10.174

[shenki]

[op-jenkins]

Can one of the admins verify this patch?

[maheshsal]

Can the kernel version be bumped to v5.10.181 ?

[runlevel5]

Looks good to me. Perhaps we could bump to v5.10.191?

Ref: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/diff/?id=v5.10.191&id2=v5.10.174&dt=2

[runlevel5]

I tried to build this on my Fedora 38 ppc64le and got following error:

>>> hcode hw062823a.opmst Building
CONFIG_FILE=/home/tle/Work/op-build/openpower/configs/hcode/ LD_LIBRARY_PATH=/home/tle/Work/op-build/output/host/usr/lib OPENPOWER_BUILD=1 CROSS_COMPILER_PATH=/home/tle/Work/op-build/output/host/powerpc64le-buildroot-linux-gnu/sysroot/ppe42-toolchain/linux PPE_TOOL_PATH=/home/tle/Work/op-build/output/host/powerpc64le-buildroot-linux-gnu/sysroot/ppe42-toolchain/linux PPE_PREFIX=/home/tle/Work/op-build/output/host/powerpc64le-buildroot-linux-gnu/sysroot/ppe42-toolchain/linux/bin/powerpc-eabi- RINGFILEPATH=/home/tle/Work/op-build/output/host/powerpc64le-buildroot-linux-gnu/sysroot/hostboot_binaries __EKB_PREFIX= CONFIG_IONV_FILE_LOCATION=/home/tle/Work/op-build/output/host/powerpc64le-buildroot-linux-gnu/sysroot/hostboot_binaries/"ionv.bin" CONFIG_INCLUDE_IONV=y bash -c 'cd /home/tle/Work/op-build/output/build/hcode-hw062823a.opmst && source ./env.bash && /usr/bin/make  '
Searching for Gerrit Host...
make[1]: Entering directory '/home/tle/Work/op-build/output/build/hcode-hw062823a.opmst'
make[3]: '../../import/../output/bin/ppetracepp.exe' is up to date.
make[3]: '../../import/../output/bin/ppetracepp.exe' is up to date.
make[3]: '../../import/../output/bin/cmeImgEdit.exe' is up to date.
make[3]: '../../import/../output/bin/stop_gpeImgEdit.exe' is up to date.
make[3]: '../../import/../output/bin/pstate_gpeImgEdit.exe' is up to date.
    DEP        p9_scan_compression.dep
    C++        p9_scan_compression.o
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C: In function ‘int rs4_embed_cmsk(CompressedScanData**, CompressedScanData*)’:
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:935:26: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  935 |     memmove(embeddedAddr + embeddedSize,
      |             ~~~~~~~~~~~~~^~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:940:11: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  940 |     memcpy(embeddedAddr,
      |     ~~~~~~^~~~~~~~~~~~~~
  941 |            i_rs4Cmsk,
      |            ~~~~~~~~~~
  942 |            embeddedSize);
      |            ~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:935:12: error: pointer ‘embeddedAddr’ may be used after ‘void* realloc(void*, size_t)’ [-Werror=use-after-free]
  935 |     memmove(embeddedAddr + embeddedSize,
      |     ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  936 |             embeddedAddr,
      |             ~~~~~~~~~~~~~
  937 |             be16toh((*io_rs4)->iv_size) - sizeof(CompressedScanData));
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../import/chips/p9/utils/imageProcs//p9_scan_compression.C:927:43: note: call to ‘void* realloc(void*, size_t)’ here
  927 |     *io_rs4 = (CompressedScanData*)realloc(*io_rs4, totalSize);
      |                                    ~~~~~~~^~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[3]: *** [../../import/chips/p9/utils/imageProcs/p9_scan_compression.mk:32: ../../import/../output/obj/p9_scan_compression/p9_scan_compression.o] Error 1
make[2]: *** [common.dir/order.final.mk:41: _BUILD/MODULE_TARGETS] Error 2
make[1]: *** [Makefile:37: all] Error 2
make[1]: Leaving directory '/home/tle/Work/op-build/output/build/hcode-hw062823a.opmst'
make: *** [package/pkg-generic.mk:251: /home/tle/Work/op-build/output/build/hcode-hw062823a.opmst/.stamp_built] Error 2
make: Leaving directory '/home/tle/Work/op-build/buildroot'

Both GCC 8.4.0 and 9.4.0 produce same error.

I've reported this issue with hcode side https://github.com/open-power/hcode/issues/4