openpomodoro-cli icon indicating copy to clipboard operation
openpomodoro-cli copied to clipboard

Question - Why does running `pomodoro break` not pause the currently running pomodoro?

Open chardskarth opened this issue 2 years ago • 7 comments

Is there a reason for this design?

chardskarth avatar Feb 26 '22 15:02 chardskarth

It could! We could change it to do a finish then break?

There's no support for pausing at the moment as I haven't figured out how to best model it.

justincampbell avatar Feb 28 '22 19:02 justincampbell

I'm okay with doing a finish then break.

Maybe pausing isn't really part of an effective pomodoro. "Once it starts, it has to ring".

chardskarth avatar Mar 11 '22 02:03 chardskarth

Also, when the break timer is running, then pomodoro status should show the break timer.

Maybe adding a formatting part like %b for break is also good idea.

mrpandey avatar Apr 15 '22 15:04 mrpandey

:+1: for this functionality including the break timer

andy-cowley avatar Jun 20 '22 13:06 andy-cowley

Right now, the finish command amends the Pomodoro's duration with the elapsed time, so if you have a 25-minute Pomodoro for instance, running finish at 20 minutes changes the Pomodoro to 20, and running at 30 changes it to 30.

If you run break at 20, I think it should amend to 20, but if you run it at 30 should it also? My assumption is yes but would like some input.

justincampbell avatar Jun 21 '22 14:06 justincampbell

@mrpandey we don't currently store the break information anywhere, but that's a good idea

justincampbell avatar Jun 21 '22 14:06 justincampbell

PR lgtm. However, I think it'd be helpful to know whether its running a break timer or a pomo timer. @justincampbell

chardskarth avatar Aug 25 '22 12:08 chardskarth