Enable LDFLAGS to be read from environment

[johanneslarsson]

We've started to build opa ourself. But for our monitoring system to work we need to be able to set LDFLAGS as input to the build command.

What is the underlying problem you're trying to solve?

Currently we have to modify the Makefile after cloning the source.

sed -i '/$(TELEMETRY_FLAG) \\/c\ LDFLAGS := "$(LDFLAGS) $(TELEMETRY_FLAG) \\' Makefile
WASM_ENABLED=0 LDFLAGS="-linkmode=external" make build

Describe the ideal solution

WASM_ENABLED=0 LDFLAGS="-linkmode=external" make build

It's a oneliner change to enable LDFLAGS to be set and I could submit a merge request if you think its valuable?

[srenatus]

It does change the contract slightly -- with the change, we better keep using LDFLAGS in the way we do to not break anyone's build scripts. I think we cannot guarantee that, but since you're building from source on your own, this might not be a problem. 🤔

I mean, noone is going to break your build on purpose, but if a future change introduces goreleaser, for example, things could have to be adapted again...

[stale[bot]]

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days. Although currently inactive, the issue could still be considered and actively worked on in the future. More details about the use-case this issue attempts to address, the value provided by completing it or possible solutions to resolve it would help to prioritize the issue.