opa
opa copied to clipboard
open-policy-agent
Bumped wasmtime-go to version 0.40.0 from 0.36.0 and updated the erro…
…r wrapping in vm.go as it was looking for an error message that was no longer present in 0.40.0, now checks if the wasm trap: interrupt is present in the Trap Message which I believe is now the correct message to check for
Signed-off-by: Peter Macdonald [email protected]
Hopefully this is okay, but please advise if I've missed something or it does not look quite right.
I've made the changes in the vm.go file and ran make test multiple times and do not see any errors.
Please let me know what you think of my approach?
Thanks!
Deploy Preview for openpolicyagent ready!
| Name | Link |
|---|---|
| Latest commit | e6b38b38523a9d791864c93b7be8b6e1d9d4704b |
| Latest deploy log | https://app.netlify.com/sites/openpolicyagent/deploys/632a9eaccff8ac00085bd059 |
| Deploy Preview | https://deploy-preview-5160--openpolicyagent.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
https://github.com/bytecodealliance/wasmtime-go/issues/151 let's hold it for a bit. We can then go straight to 1.0 and save ourselves one set of library binaries in our git history 😅
https://github.com/bytecodealliance/wasmtime-go/issues/151 let's hold it for a bit. We can then go straight to 1.0 and save ourselves one set of library binaries in our git history 😅
Sounds good to me!
Hey @srenatus,
Still a little confused with git in bigger projects, have I done the right thing here with this PR? Not sure if I should have forced pushed...
Please let me know thanks!
Looks good! Could you please squash the two commits into one and adjust the message? Also take care of dco, please.
Thanks!
Looks good! Could you please squash the two commits into one and adjust the message? Also take care of dco, please.
Thanks!
Hey! :wave:
Should be good now?
Thanks again!
Thanks again. I've edited the commit message a bit, hope you don't mind.
No problem at all!