opa icon indicating copy to clipboard operation
opa copied to clipboard

Support opa-envoy linux/arm64 Docker Image

Open Nebu1eto opened this issue 3 years ago • 18 comments

What is the underlying problem you're trying to solve?

I'm using opa-envoy, but it doesn't support linux/arm64 architecture. So I can't use this on Graviton 2 (AWS).

Describe the ideal solution

If there are no problem to build opa-envoy image for arm64, can you please support this? If not, It is issue and it have to be resolved.

Nebu1eto avatar Aug 04 '22 08:08 Nebu1eto

There's no technical reason not to do it; it's just work that needs to be done. Would you be interested in adding the steps done with OPA in https://github.com/open-policy-agent/opa/commit/db4d9872ccf3ec1d25165d18ba7d8891af3e4276 with opa-envoy-plugin...?

srenatus avatar Aug 15 '22 12:08 srenatus

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

stale[bot] avatar Sep 14 '22 17:09 stale[bot]

can we please have this?

sidharthramesh avatar Oct 25 '22 19:10 sidharthramesh

Contributions welcome! Happy to assist.

The setup here could also be simpler than what OPA does: since no cgo is needed, we could use ko.

srenatus avatar Oct 26 '22 05:10 srenatus

Thank you @srenatus. I'll get started on this. CC: @Areefks

sidharthramesh avatar Oct 26 '22 14:10 sidharthramesh

@srenatus Ko seems to do all of the heavy lifting of multiarch image builds. Should I replace all of these lines with Ko's CLI instead of docker build?

https://github.com/open-policy-agent/opa-envoy-plugin/blob/c37ea9d489b8f8144d449abbe294a1d6cde7ffa2/Makefile#L86-L111

sidharthramesh avatar Nov 12 '22 12:11 sidharthramesh

@srenatus Do we need the whole replacing the Dockerfile arch business when we switch to Ko?

sed -e 's/GOARCH/$(GOARCH)/g' Dockerfile > .Dockerfile_$(GOARCH)

sidharthramesh avatar Nov 12 '22 12:11 sidharthramesh

Where exactly is the docker build happening?

https://github.com/open-policy-agent/opa-envoy-plugin/blob/c37ea9d489b8f8144d449abbe294a1d6cde7ffa2/.github/workflows/post-tag.yaml#L23 this doesn't seem to be building the images, only the binaries?

sidharthramesh avatar Nov 12 '22 12:11 sidharthramesh

https://github.com/open-policy-agent/opa/blob/main/.github/workflows/post-merge.yaml#L160 should do it, at least the -edge images.

srenatus avatar Nov 12 '22 15:11 srenatus

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

stale[bot] avatar Dec 12 '22 22:12 stale[bot]

+1

3goats avatar Apr 03 '24 20:04 3goats