gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

chore: Move to maintained yaml library

Open mrueg opened this issue 1 month ago β€’ 8 comments

What this PR does / why we need it: gopkg.in/yaml is unmaintained, this moves the dependency to a maintained yaml library https://github.com/yaml/go-yaml which is also used by https://github.com/kubernetes-sigs/yaml?tab=readme-ov-file#compatibility (which is used in gatekeeper as well)

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Special notes for your reviewer:

mrueg avatar Nov 08 '25 00:11 mrueg

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 40.65%. Comparing base (3350319) to head (33f702f). :warning: Report is 531 commits behind head on master.

:exclamation: There is a different number of reports uploaded between BASE (3350319) and HEAD (33f702f). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (33f702f)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4227       +/-   ##
===========================================
- Coverage   54.49%   40.65%   -13.84%     
===========================================
  Files         134      251      +117     
  Lines       12329    17723     +5394     
===========================================
+ Hits         6719     7206      +487     
- Misses       5116     9891     +4775     
- Partials      494      626      +132     
Flag Coverage Ξ”
unittests 40.65% <ΓΈ> (-13.84%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 08 '25 00:11 codecov-commenter

@mrueg can you resolve conflict?

JaydipGabani avatar Nov 22 '25 00:11 JaydipGabani

@mrueg can you resolve conflict?

Rebased.

mrueg avatar Nov 28 '25 21:11 mrueg

do we need to vendor this? lgtm otherwise, thanks!

sozercan avatar Dec 02 '25 00:12 sozercan

@mrueg plesae fix the conflicts.

JaydipGabani avatar Dec 09 '25 23:12 JaydipGabani

@mrueg can you address the feedback above?

JaydipGabani avatar Dec 11 '25 21:12 JaydipGabani

@JaydipGabani which one? The one from CoPilot seems to be wrong, as it effectively reverts this change.

mrueg avatar Dec 11 '25 22:12 mrueg

Ohh nvm, I thought the earlier feedback was not addressed, we can dismiss copilot one. My appologies.

JaydipGabani avatar Dec 11 '25 22:12 JaydipGabani