gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

Add ability to set labels on Deployment

Open DanTulovsky opened this issue 1 year ago • 4 comments

Describe the solution you'd like

Much like we can set labels on pods with podLabels it would be useful to have the ability to set labels on the Deployment objects as well. For example, we would like to set a app.kubernetes.io/name label on the Deployment and there is no way to do this with the existing chart.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Gatekeeper version: All
  • Kubernetes version: (use kubectl version): All

DanTulovsky avatar Jun 21 '24 14:06 DanTulovsky

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 21 '24 02:08 stale[bot]

This doesn't look like it's completed...

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: '{{ template "gatekeeper.name" . }}'
    chart: '{{ template "gatekeeper.name" . }}'
    control-plane: controller-manager
    gatekeeper.sh/operation: webhook
    gatekeeper.sh/system: "yes"
    heritage: '{{ .Release.Service }}'
    release: '{{ .Release.Name }}'
  name: gatekeeper-controller-manager
  namespace: '{{ .Release.Namespace }}'

DanTulovsky avatar Sep 04 '24 14:09 DanTulovsky

It got closed due to staleness.

For anyone who is interested in adding this, PTAL how pod labels were add for inspiration: https://github.com/open-policy-agent/gatekeeper/pull/3378/files

ritazh avatar Sep 05 '24 00:09 ritazh

@ritazh, I am interested to contribute, could you assign it to me

prakrit55 avatar Oct 07 '24 10:10 prakrit55

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 08 '24 08:12 stale[bot]