gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard

chore: Changed the process to expand yaml so that maxUnavailable, etc. can be used.

Open kahirokunn opened this issue 1 year ago β€’ 11 comments

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged): Fixes #

Special notes for your reviewer:

kahirokunn avatar Dec 24 '23 10:12 kahirokunn

@kahirokunn thanks for the PR! Gatekeeper helm chart is autogenerated and these changes will be clobbered in the next release. Please refer to Contributing to Helm Chart for modifying the Helm chart.

sozercan avatar Jan 08 '24 23:01 sozercan

@sozercan thx. done.

kahirokunn avatar Jan 30 '24 02:01 kahirokunn

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.48%. Comparing base (0bac5b0) to head (a51aff0). Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3199      +/-   ##
==========================================
- Coverage   54.49%   54.48%   -0.02%     
==========================================
  Files         134      134              
  Lines       12329    12329              
==========================================
- Hits         6719     6717       -2     
- Misses       5117     5118       +1     
- Partials      493      494       +1     
Flag Coverage Ξ”
unittests 54.48% <ΓΈ> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 12 '24 19:02 codecov-commenter

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 28 '24 22:04 stale[bot]

@sozercan Hello πŸ‘€

kahirokunn avatar Apr 29 '24 00:04 kahirokunn

@kahirokunn can you instead changing vairable minAvailable, introduce a new variable maxUnavailable and respective field in PDB? that way by not chaning original variable we are not breaking users(that are using maxAvailable variable).

JaydipGabani avatar May 15 '24 19:05 JaydipGabani

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 14 '24 21:07 stale[bot]

/reopen

kahirokunn avatar Jul 30 '24 05:07 kahirokunn

@JaydipGabani Introducing a new variable, maxUnavailable, instead of changing minAvailable is a thoughtful suggestion to avoid breaking existing users. However, minAvailable and maxUnavailable cannot be specified together as they are mutually exclusive. Adding maxUnavailable alone will not function correctly in the current setup.

kahirokunn avatar Jul 30 '24 05:07 kahirokunn

@sozercan Hi 😒

kahirokunn avatar Jul 30 '24 05:07 kahirokunn