gatekeeper icon indicating copy to clipboard operation
gatekeeper copied to clipboard
verified publisher icon open-policy-agent

Publish GK under v0.3.x for go get

Open ritazh opened this issue 3 years ago • 6 comments

Describe the solution you'd like [A clear and concise description of what you want to happen.] Per https://github.com/open-policy-agent/gatekeeper/pull/2083#issuecomment-1163358503, we need to publish GK under v0.3.x to ensure go get github.com/open-policy-agent/[email protected] works. As part of this work, we also need to update GK's release process to ensure 2 tags are pushed for every release, one for GK v3.x.x and one for GK v0.3.x.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

  • Gatekeeper version:
  • Kubernetes version: (use kubectl version):

ritazh avatar Jun 23 '22 06:06 ritazh

v0.3.x.x?

maxsmythe avatar Jun 24 '22 00:06 maxsmythe

v0.3.x.x?

I think https://semver.org/ wants the MAJOR.MINOR.PATCH format. How about we follow Kubernetes https://github.com/kubernetes/client-go#versioning

For each v1.x.y Kubernetes release, the major version (first digit) would remain 0.

So v3.8.1 --> v0.8.1 ?

ritazh avatar Jun 24 '22 01:06 ritazh

Ah, thought they just shifted everything right. The above SGTM

maxsmythe avatar Jun 24 '22 23:06 maxsmythe

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Aug 30 '22 23:08 stale[bot]

@ritazh I think we still want this?

maxsmythe avatar Sep 13 '22 23:09 maxsmythe

yes!

ritazh avatar Sep 14 '22 02:09 ritazh

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 14 '22 01:11 stale[bot]

Is this still being worked on? This would be very valuable to be able to utilize some packages in pkg/gator and the like for static analysis.

mccormickt-dd avatar May 02 '23 14:05 mccormickt-dd

Not actively, but not b/c it's not a good idea. @sozercan any idea how much work this would be?

maxsmythe avatar May 04 '23 01:05 maxsmythe

I am not sure if it's possible to use v0.3.x without updating the tags (basically, cutting v0.3.x and gatekeeper-3.x) , which might break things for some users that rely on existing v3.x tags etc. (example k8s.io/api https://github.com/kubernetes/api/tags)

We can append /v3 in GK go.mod to properly fix this issue, but this will break any deps from other projects to GK.

I think with either of these options, it will break some users and whether this tradeoff is worth the breakage.

sozercan avatar May 04 '23 23:05 sozercan

Should be fixed by #2742

sozercan avatar May 11 '23 17:05 sozercan