frameworks icon indicating copy to clipboard operation
frameworks copied to clipboard

Remove the notion of "Enforcement Action" from the engine interface

Open maxsmythe opened this issue 1 year ago • 2 comments

Currently, Engine is responsible for returning an enforcement action. This was originally intended to allow for the possibility of dynamic enforcement actions, but that would be incompatible with the capabilities of the CEL KEP. As such, it should be removed.

https://github.com/open-policy-agent/frameworks/blob/9f70a3e5e75db72a81c79c26dd358feb027ddcf5/constraint/pkg/client/drivers/to_result.go#L82-L90

maxsmythe avatar Feb 27 '23 23:02 maxsmythe

What kind of impact/issue does removing "Enforcement Action" present? Will there be any backward compatibility issues?

ritazh avatar Mar 04 '23 00:03 ritazh

No user-facing backwards compatibility issues... we never piped this through to users. Anyone who has written a driver may be affected, but I'm not aware of anyone whose done that (and that part of the CF is alpha).

maxsmythe avatar Mar 04 '23 01:03 maxsmythe