cert-controller icon indicating copy to clipboard operation
cert-controller copied to clipboard

fix: Ensure that insecureSkipTLSVerify is false before setting caBundle on APIService

Open JorTurFer opened this issue 1 year ago • 5 comments

If the APIService has already registered the value insecureSkipTLSVerify: true, cert-controller fails patching the APIService because caBundle and insecureSkipTLSVerify: true aren't compatible. This PR updates the behaviour to ensure that insecureSkipTLSVerify is false before setting the caBundle

JorTurFer avatar Nov 21 '23 11:11 JorTurFer

Codecov Report

Attention: Patch coverage is 60.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 60.13%. Comparing base (190188d) to head (b6466d0).

Files Patch % Lines
pkg/rotator/rotator.go 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   57.16%   60.13%   +2.97%     
==========================================
  Files           1        1              
  Lines         572      577       +5     
==========================================
+ Hits          327      347      +20     
+ Misses        181      170      -11     
+ Partials       64       60       -4     
Flag Coverage Δ
unittests 60.13% <60.00%> (+2.97%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Nov 30 '23 23:11 codecov-commenter

Hello! Any update about this?

JorTurFer avatar Dec 12 '23 08:12 JorTurFer

Hello @ritazh @maxsmythe Sorry for linking you directly, but this PR hasn't got any answer for a month. Could you review it please?

JorTurFer avatar Jan 14 '24 15:01 JorTurFer

Hello ✋ Can this be merged?

JorTurFer avatar Feb 06 '24 23:02 JorTurFer

@JorTurFer We are waiting on lgtm from @maxsmythe as well.

JaydipGabani avatar Feb 07 '24 01:02 JaydipGabani