Fix a bunch of compiler warnings in "make check"

[jsquyres]

There were many compiler warnings, making it difficult to read if there were real issues that needed to be addressed.

Signed-off-by: Jeff Squyres [email protected]

[jjhursey]

IBM CI had a bad weekend (sorry about that). We should be all good now. bot:ibm:pgi:retest bot:ibm:xl:retest

[gpaulsen]

@jsquyres Can you please rebase? This may be important.

[gpaulsen]

bot:retest /azp run bot:ibm:retest

[gpaulsen]

bot:ibm:retest

[jjhursey]

Any reason to hold this PR any longer? (other than it need to be rebased)

[gpaulsen]

I rebased on tip of main(no code change).

[jsquyres]

If that 3rd commit passes CI properly, you'll squash it appropriately, right? (minor pet peeve: make a commit on a PR and then make a later commit on the same PR to fix the earlier commit)

[gpaulsen]

mellanox CI failed that it couldn't find a definition for the non-sized versions of these, and I searched around and couldn't find those definitions either, so I created the 3rd commit. Why the other CIs didn't fail, I'm not sure. @bwbarrett thoughts?

[gpaulsen]

I git bisected opal/include/opal/sys/atomic_stdc.h and couldn't find a definition for opal_atomic_compare_exchange_strong anywhere in the past.

[bwbarrett]

bot:aws:retest