ompi icon indicating copy to clipboard operation
ompi copied to clipboard

MTLs are inappropriately calling exit() or abort()

Open mwheinz opened this issue 4 years ago • 6 comments

As a part of discussing #7699, it was pointed out that there are several error paths in the OFI MTL that call exit() and several in the Portals MTL that call abort(). These are inappropriate and need to be rethought, possibly replacing them with calls to ompi_rte_abort().

mwheinz avatar May 12 '20 16:05 mwheinz

@mwheinz can this issue be closed?

awlauria avatar Apr 22 '21 13:04 awlauria

@mwheinz can this issue be closed?

No, these problems still exist in the OFI provider. Assigning it to myself since there doesn't seem to be anyone in particular maintaining the OFI MTL.

mwheinz avatar Apr 22 '21 14:04 mwheinz

I can't promise to get to this anytime soon but I've added it to my internal bug queue. It's low priority because it's been in the code without complaint since 2018.

mwheinz avatar Apr 22 '21 14:04 mwheinz

No worries - thanks.

awlauria avatar Apr 22 '21 14:04 awlauria

@mwheinz Going over older issues, is this still relevant?

janjust avatar Feb 08 '24 17:02 janjust

Unfortunately I no longer work for that company and I haven't worked on Open MPI since 2021.

mwheinz avatar Feb 08 '24 17:02 mwheinz

closing as stale

janjust avatar Apr 18 '24 16:04 janjust