ompi icon indicating copy to clipboard operation
ompi copied to clipboard

configury: harden IGNORE_TKR check

Open ggouaillardet opened this issue 1 year ago • 5 comments

NVIDIA HPC Compiler (e.g. nvfortran) incorrectly selected the GCC style pragmas to support IGNORE_TKR. Harden the test by mimicking exactly the mpi f08 bindings in order to fix that false positive.

Thanks Chris Parrot for the report.

Refs. open-mpi/ompi#11582

Signed-off-by: Gilles Gouaillardet [email protected] bot:notacherrypick (back-ported from commit 600df6aa57a473f17041e34a0a583db4acefe213)

ggouaillardet avatar Jul 24 '24 04:07 ggouaillardet

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5660c69f: configury: harden IGNORE_TKR check

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 24 '24 04:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

194d8a52: configury: harden IGNORE_TKR check

  • check_cherry_pick: does not include a cherry pick message (did you need to bot:notacherrypick?)

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 24 '24 04:07 github-actions[bot]

:bot:retest

ggouaillardet avatar Jul 24 '24 05:07 ggouaillardet

bot:aws:retest

wenduwan avatar Jul 25 '24 14:07 wenduwan

Odd...

I updated the PR to fix

ERROR: files left in build directory after distclean:
./check_ignore_tkr.mod

not sure why other branches were happy though...

ggouaillardet avatar Jul 25 '24 16:07 ggouaillardet

@ggouaillardet is there a reason this PR is still in draft? Is it ready / can we close it?

bwbarrett avatar Oct 27 '25 15:10 bwbarrett

#12861 (and backports if any) addressed the issue, I am closing this PR.

ggouaillardet avatar Oct 27 '25 23:10 ggouaillardet