ompi icon indicating copy to clipboard operation
ompi copied to clipboard

Published 20 hours ago • verified publisher icon open-mpi

datatype: Add support for MPI_TYPECLASS_LOGICAL

Open dalcinl opened this issue 1 year ago • 2 comments
trafficstars

Support for MPI_TYPECLASS_LOGICAL as being proposed in mpi-forum/mpi-issues#699.

As a bonus, add preliminary support the MPI_LOGICAL16 datatype.

TODO: Support for 128bit integral C types via GCC/LLVM __int128 extension.

dalcinl avatar Mar 21 '24 15:03 dalcinl

Hello! The Git Commit Checker CI bot found a few problems with this PR:

7b93c9db: datatype: Add support for MPI_TYPECLASS_LOGICAL

  • check_signed_off: does not contain a valid Signed-off-by line

64e5f5f4: datatype: Add preliminary support for MPI_LOGICAL1...

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Mar 21 '24 15:03 github-actions[bot]

I believe I forgot to bump OMPI_DATATYPE_MAX_PREDEFINED by one.

dalcinl avatar Mar 21 '24 17:03 dalcinl