ompi icon indicating copy to clipboard operation
ompi copied to clipboard

Published 20 hours ago • verified publisher icon open-mpi

Generate bigcount interfaces for Fortran and C

Open jtronge opened this issue 1 year ago • 27 comments

This adds scripts for generating the C and Fortran mpi_f08 API bindings from template files, while also generating bigcount interfaces for those that require them. On the Fortran side it also adds support for TS 29113 when possible, allowing for better Fortran array handling that matches the standard (some files were imported from PR #10302).

Python >=3.6 is required for running these scripts, which is only necessary when the binding files have not already been generated. Users of the distribution tarball should not need to generate these files and thus should not require Python.

We used https://github.com/cea-hpc/pcvs-benchmarks and the MPI4PY test suite to help ensure all big count interfaces (C and Fortran) are being generated.

PR #12033 is a previous version of this focused specifically on ABI support.

jtronge avatar Jan 10 '24 21:01 jtronge

Should https://github.com/open-mpi/ompi/pull/12033 be closed (if this PR wholly replaces it)?

jsquyres avatar Feb 07 '24 16:02 jsquyres

I think I'll try to remove the extra standard ABI code from the script, as well as the additional items you caught @jsquyres.

I don't think this code completely replaces PR #12033, especially since that one includes the refactor of libmpi into multiple libraries that we discussed.

jtronge avatar Feb 07 '24 17:02 jtronge

/azp run

jtronge avatar Feb 14 '24 22:02 jtronge

Hello! The Git Commit Checker CI bot found a few problems with this PR:

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 01 '24 21:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 01 '24 21:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 01 '24 21:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 03 '24 15:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 16 '24 21:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 17 '24 16:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 17 '24 17:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 18 '24 16:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 22 '24 16:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 22 '24 16:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 23 '24 14:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 24 '24 17:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

51270294: Add ELEMENT_COUNT for MPI_Get_elements_x

  • check_signed_off: does not contain a valid Signed-off-by line

fc151a85: Add DATATYPE, STATUS, and GREQUEST_ types*

  • check_signed_off: does not contain a valid Signed-off-by line

e673867b: Add int, char, and MPI_Info-related types

  • check_signed_off: does not contain a valid Signed-off-by line

01fa44e0: Add PARTITIONED_COUNT type

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Apr 24 '24 21:04 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

f49c8350: Move ompi_binding parser code into separate file

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 26 '24 17:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

e05f6ce3: fortran/use-mpi-f08: add CFI support for one sided...

  • check_signed_off: does not contain a valid Signed-off-by line

5da1e2e7: fortran/use-mpi-f08: add CFI support for MPI-IO op...

  • check_signed_off: does not contain a valid Signed-off-by line

6b3ee030: Remove mpi-f08-rename.h

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 30 '24 20:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5bf32869: fortran/use-mpi-f08: add CFI support for pack subr...

  • check_signed_off: does not contain a valid Signed-off-by line

43096fb7: fortran/use-mpi-f08: add CFI support for (blocking...

  • check_signed_off: does not contain a valid Signed-off-by line

e05f6ce3: fortran/use-mpi-f08: add CFI support for one sided...

  • check_signed_off: does not contain a valid Signed-off-by line

5da1e2e7: fortran/use-mpi-f08: add CFI support for MPI-IO op...

  • check_signed_off: does not contain a valid Signed-off-by line

6b3ee030: Remove mpi-f08-rename.h

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 30 '24 20:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5bf32869: fortran/use-mpi-f08: add CFI support for pack subr...

  • check_signed_off: does not contain a valid Signed-off-by line

43096fb7: fortran/use-mpi-f08: add CFI support for (blocking...

  • check_signed_off: does not contain a valid Signed-off-by line

e05f6ce3: fortran/use-mpi-f08: add CFI support for one sided...

  • check_signed_off: does not contain a valid Signed-off-by line

5da1e2e7: fortran/use-mpi-f08: add CFI support for MPI-IO op...

  • check_signed_off: does not contain a valid Signed-off-by line

6b3ee030: Remove mpi-f08-rename.h

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 31 '24 15:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5bf32869: fortran/use-mpi-f08: add CFI support for pack subr...

  • check_signed_off: does not contain a valid Signed-off-by line

43096fb7: fortran/use-mpi-f08: add CFI support for (blocking...

  • check_signed_off: does not contain a valid Signed-off-by line

e05f6ce3: fortran/use-mpi-f08: add CFI support for one sided...

  • check_signed_off: does not contain a valid Signed-off-by line

5da1e2e7: fortran/use-mpi-f08: add CFI support for MPI-IO op...

  • check_signed_off: does not contain a valid Signed-off-by line

6b3ee030: Remove mpi-f08-rename.h

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Jul 31 '24 15:07 github-actions[bot]

Hello! The Git Commit Checker CI bot found a few problems with this PR:

5bf32869: fortran/use-mpi-f08: add CFI support for pack subr...

  • check_signed_off: does not contain a valid Signed-off-by line

43096fb7: fortran/use-mpi-f08: add CFI support for (blocking...

  • check_signed_off: does not contain a valid Signed-off-by line

e05f6ce3: fortran/use-mpi-f08: add CFI support for one sided...

  • check_signed_off: does not contain a valid Signed-off-by line

5da1e2e7: fortran/use-mpi-f08: add CFI support for MPI-IO op...

  • check_signed_off: does not contain a valid Signed-off-by line

6b3ee030: Remove mpi-f08-rename.h

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

github-actions[bot] avatar Aug 01 '24 12:08 github-actions[bot]