ompi icon indicating copy to clipboard operation
ompi copied to clipboard

Published 20 hours ago • verified publisher icon open-mpi

osc/rdma: fix data integrity issue in rdma get_accumulate

Open AboorvaDevarajan opened this issue 3 years ago • 2 comments

  • Use the start of the result buffer pointer to unpack the data. (Fixes a data integrity issue)
  • Fix memory leak in the non-contig get_accumulate code path.

Signed-off-by: Aboorva Devarajan [email protected]

AboorvaDevarajan avatar Aug 08 '22 06:08 AboorvaDevarajan

When this PR is complete, will it need to be cherry-picked back to v4.1.x and v4.0.x, too?

jsquyres avatar Aug 08 '22 17:08 jsquyres

When this PR is complete, will it need to be cherry-picked back to v4.1.x and v4.0.x, too?

Jeff, this test passes in v4.0.x (with osc rdma) and the issue seems to be introduced in v4.1.x so we can back-port this fix to v4.1.x and v5.0.x branches once merged.

AboorvaDevarajan avatar Aug 09 '22 08:08 AboorvaDevarajan

@AboorvaDevarajan Can you please backport this fix to the release branches?

devreal avatar Aug 11 '22 18:08 devreal