ompi icon indicating copy to clipboard operation
ompi copied to clipboard

Published 20 hours ago • verified publisher icon open-mpi

Coll han: fix allreduce dynamic calling internal han algo on sub_comm

Open FlorentGermain-Bull opened this issue 2 years ago • 8 comments

Fix for #8248 (a little bit late). This PR reactivates the dynamic mechanism and corrects the initial bug. To make it simple, the dynamic had a bug that caused a call to an internal han implementation on a sub_communicator but with a wrong module, leading to a segfault.

FlorentGermain-Bull avatar Jun 08 '22 12:06 FlorentGermain-Bull

Can one of the admins verify this patch?

ompiteam-bot avatar Jun 08 '22 12:06 ompiteam-bot

ok to test

awlauria avatar Jun 08 '22 12:06 awlauria

bot:ibm:retest

jjhursey avatar Jun 08 '22 17:06 jjhursey

bot:ibm:retest

jjhursey avatar Jun 09 '22 00:06 jjhursey

Can this get a review?

awlauria avatar Jul 14 '22 14:07 awlauria

@bosilca ?

jsquyres avatar Jul 19 '22 14:07 jsquyres

@bosilca is this good to go?

awlauria avatar Aug 02 '22 16:08 awlauria

@bosilca ping do you agree with the change?

awlauria avatar Aug 19 '22 15:08 awlauria

@FlorentGermain-Bull Can you rebase this PR so that it picks up the new CI? Thanks!

jsquyres avatar Sep 28 '22 15:09 jsquyres