ompi icon indicating copy to clipboard operation
ompi copied to clipboard

smsc/xpmem: alignment and stack memory space

Open devreal opened this issue 3 years ago • 5 comments

This PR addresses two issues identified in https://github.com/open-mpi/ompi/issues/10121:

  1. The aligned upper bound was off by 1.
  2. We may not be able to map the full aligned range if the memory points to the stack. In that case we should try again with the requested upper bound.

Signed-off-by: Joseph Schuchart [email protected]

devreal avatar Mar 16 '22 13:03 devreal

Bounds when it comes to rcache registration are the last byte of the range. Probably doesn't matter much here as no rcache is in use.

hjelmn avatar Mar 17 '22 04:03 hjelmn

I changed the fallback to align to the actual page size, which seems to work as well and reduces the number of times we may need to remap until we have mapped all the relevant stack positions mapped.

devreal avatar Mar 18 '22 14:03 devreal

@hjelmn Can you please take a look at this PR?

devreal avatar May 10 '22 15:05 devreal

Rebased to current main. Can someone please review?

devreal avatar Sep 19 '22 18:09 devreal

bot:aws:retest

bwbarrett avatar Sep 20 '22 19:09 bwbarrett

@devreal I think you'll want to rebase and force push again.

awlauria avatar Oct 12 '22 13:10 awlauria

bot:aws:retest

awlauria avatar Oct 13 '22 13:10 awlauria