ompi
ompi copied to clipboard
smsc/xpmem: alignment and stack memory space
This PR addresses two issues identified in https://github.com/open-mpi/ompi/issues/10121:
- The aligned upper bound was off by 1.
- We may not be able to map the full aligned range if the memory points to the stack. In that case we should try again with the requested upper bound.
Signed-off-by: Joseph Schuchart [email protected]
Bounds when it comes to rcache registration are the last byte of the range. Probably doesn't matter much here as no rcache is in use.
I changed the fallback to align to the actual page size, which seems to work as well and reduces the number of times we may need to remap until we have mapped all the relevant stack positions mapped.
@hjelmn Can you please take a look at this PR?
Rebased to current main. Can someone please review?
bot:aws:retest
@devreal I think you'll want to rebase and force push again.
bot:aws:retest