mmtracking icon indicating copy to clipboard operation
mmtracking copied to clipboard

[Feature] Support test of MixFormer for SOT

Open songtianhui opened this issue 2 years ago • 7 comments

songtianhui avatar Aug 03 '22 17:08 songtianhui

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK.

JingweiZhang12 avatar Aug 06 '22 12:08 JingweiZhang12

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK.

In unit tests, run unittests section the error message is as below

E               ImportError: Please run pip install git+https://github.com/TAO-Dataset/tao.git to manually install tao

mmtrack/datasets/tao_dataset.py:218: ImportError

E               ImportError: Please runpip install git+https://github.com/JonathonLuiten/TrackEval.gitto manually install trackeval

mmtrack/datasets/mot_challenge_dataset.py:438: ImportError

It should not be a bug in my implementation, how can I fix it? Add this package in requirements?

songtianhui avatar Aug 09 '22 11:08 songtianhui

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK.

In unit tests, run unittests section the error message is as below

E               ImportError: Please run pip install git+https://github.com/TAO-Dataset/tao.git to manually install tao

mmtrack/datasets/tao_dataset.py:218: ImportError

E               ImportError: Please runpip install git+https://github.com/JonathonLuiten/TrackEval.gitto manually install trackeval

mmtrack/datasets/mot_challenge_dataset.py:438: ImportError

It should not be a bug in my implementation, how can I fix it? Add this package in requirements?

It lacks some of the third libs used in MOT. You can run pip install .. according to the error infos.

JingweiZhang12 avatar Aug 10 '22 02:08 JingweiZhang12

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK.

In unit tests, run unittests section the error message is as below

E               ImportError: Please run pip install git+https://github.com/TAO-Dataset/tao.git to manually install tao

mmtrack/datasets/tao_dataset.py:218: ImportError

E               ImportError: Please runpip install git+https://github.com/JonathonLuiten/TrackEval.gitto manually install trackeval

mmtrack/datasets/mot_challenge_dataset.py:438: ImportError

It should not be a bug in my implementation, how can I fix it? Add this package in requirements?

It lacks some of the third libs used in MOT. You can run pip install .. according to the error infos.

I know that I can run pip install in my local pc. But this failure happened in ci unit tests, for example you can check this. And I cannot control the server program. I think that maybe the test pipeline lacks this pip install ... command for the two libs?

songtianhui avatar Aug 10 '22 11:08 songtianhui

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK.

In unit tests, run unittests section the error message is as below

E               ImportError: Please run pip install git+https://github.com/TAO-Dataset/tao.git to manually install tao

mmtrack/datasets/tao_dataset.py:218: ImportError

E               ImportError: Please runpip install git+https://github.com/JonathonLuiten/TrackEval.gitto manually install trackeval

mmtrack/datasets/mot_challenge_dataset.py:438: ImportError

It should not be a bug in my implementation, how can I fix it? Add this package in requirements?

It lacks some of the third libs used in MOT. You can run pip install .. according to the error infos.

I know that I can run pip install in my local pc. But this failure happened in ci unit tests, for example you can check this. And I cannot control the server program. I think that maybe the test pipeline lacks this pip install ... command for the two libs?

Werid! Anyway, leave it alone because the CI in the branch of master is deprecated. You can run pytest on your local machine. If all unit tests pass, it's OK. BYW, if this PR is ready for review again, you can click the re-request review button on the top right corner of this page.

JingweiZhang12 avatar Aug 11 '22 06:08 JingweiZhang12

Please complete all unit tests and docstrings and make sure all unit tests pass. You can refer to the implementation of STARK. Also, I noticed that this PR uses lots of rearrange operation? It's a little ugly. Do you think they are repeated and redundant somewhere and can be simplified?

JingweiZhang12 avatar Aug 12 '22 13:08 JingweiZhang12

In order to facilitate later maintenance and secondary development, please add unit tests of forward for these important functions or classes: MixformerHead, MixFormer, MixFormerBackbone. You can refer to SiamRPN and STARK.

JingweiZhang12 avatar Sep 24 '22 03:09 JingweiZhang12

All the UTs run successfully on the local computer. LGTM @GT9505

JingweiZhang12 avatar Oct 01 '22 07:10 JingweiZhang12

Dear songtianhui, First of all, we want to express our gratitude for your significant PR in the MMTracking project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR. If you are Chinese or have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG Thank you again for your contribution❤ Best regards! @songtianhui

OpenMMLab-Assistant005 avatar Mar 31 '23 07:03 OpenMMLab-Assistant005