mmsegmentation icon indicating copy to clipboard operation
mmsegmentation copied to clipboard

Make mmseg to be able to run on mmcv=2.2.0

Open rabinadk1 opened this issue 1 year ago • 4 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The documentation says it is okay to run with mmcv >= 2.2.0, but mmseg incorrectly asserts it to be less than 2.2.0.

Modification

  1. Allow mmcv with version 2.2.0 to run with the latest mmseg package.
  2. Separate the assertion for the package version checks into two statements to provide users with clear feedback on whether their version is less or more than the required range.

BC-breaking (Optional)

No

Use cases (Optional)

N/A

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

rabinadk1 avatar May 09 '24 07:05 rabinadk1

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 09 '24 07:05 CLAassistant

can we get this merged?

kabouzeid avatar Jul 23 '24 15:07 kabouzeid

can we get this merged?

I believe it's OK, but I am just a contributor without merge permission. This project has been paused for several months.

----From a dissappointed contributor.........

MGAMZ avatar Jul 23 '24 15:07 MGAMZ

@mmeendez8 @Zoulinx @xiexinch

kabouzeid avatar Jul 23 '24 15:07 kabouzeid