mmpretrain icon indicating copy to clipboard operation
mmpretrain copied to clipboard

[Feature] File names in result

Open okotaku opened this issue 2 years ago • 3 comments

Motivation

Put 'filenames' in test.py out_items to describe which file the result is.

Checklist

Before PR:

  • [x] Pre-commit or other linting tools are used to fix the potential lint issues.
  • [x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • [x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • [x] CLA has been signed and all committers have signed the CLA in this PR.

okotaku avatar Jul 06 '22 05:07 okotaku

Codecov Report

Merging #896 (b33ee14) into dev (812f3d4) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #896      +/-   ##
==========================================
- Coverage   85.45%   85.44%   -0.01%     
==========================================
  Files         132      132              
  Lines        8750     8769      +19     
  Branches     1513     1516       +3     
==========================================
+ Hits         7477     7493      +16     
- Misses       1050     1052       +2     
- Partials      223      224       +1     
Flag Coverage Δ
unittests 85.39% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/datasets/base_dataset.py 99.00% <100.00%> (+0.03%) :arrow_up:
mmcls/datasets/cifar.py 85.71% <100.00%> (+0.78%) :arrow_up:
mmcls/datasets/dataset_wrappers.py 73.33% <100.00%> (+1.50%) :arrow_up:
mmcls/datasets/mnist.py 78.26% <100.00%> (+0.98%) :arrow_up:
mmcls/datasets/builder.py 83.78% <0.00%> (-4.06%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 11df205...b33ee14. Read the comment docs.

codecov[bot] avatar Jul 06 '22 05:07 codecov[bot]

I think gt_labels also be put in out_items. What do you think?

okotaku avatar Jul 07 '22 00:07 okotaku

I think gt_labels also be put in out_items. What do you think?

Yes, it is a good idea if gt_labels is available as an option. This is useful for analyzing results.

Ezra-Yu avatar Jul 07 '22 04:07 Ezra-Yu