mmpretrain icon indicating copy to clipboard operation
mmpretrain copied to clipboard

Published 20 hours ago • verified publisher icon open-mmlab

delete DistOptHook

Open HarborYuan opened this issue 2 years ago • 4 comments

#786

Not tested code. Does the current CI can cover?

@mzr1996

Thanks for review.

HarborYuan avatar Apr 16 '22 08:04 HarborYuan

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 16 '22 08:04 CLAassistant

By the way, it seems that https://github.com/open-mmlab/mmclassification/blob/6beac5060f0c1d57141642dba77c19c9ed6b3873/mmcls/core/utils/dist_utils.py#L62 is also duplicated with the mmdetection version of seed broadcasting.

HarborYuan avatar Apr 16 '22 08:04 HarborYuan

Seems that needs to delete DistOptHook test codes, do I need to do so?

HarborYuan avatar Apr 16 '22 15:04 HarborYuan

@mzr1996 Thanks for the review. Is there something else that needs to be done?

HarborYuan avatar Apr 19 '22 06:04 HarborYuan