mmpose icon indicating copy to clipboard operation
mmpose copied to clipboard

[add] ConcatDataset.evaluate feature

Open 17862923747 opened this issue 2 years ago • 4 comments

Motivation

多数据集场景,val时会报错,因为您的ConcatDataset.evaluate没有实现

Modification

我补充了缺少的这部分代码:ConcatDataset.evaluate

BC-breaking (Optional)

可兼容已有代码和config

Use cases (Optional)

Checklist

Before PR:

  • [x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [x] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [x] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [x] New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • [x] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [x] CLA has been signed and all committers have signed the CLA in this PR.

17862923747 avatar Jan 13 '23 03:01 17862923747

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 13 '23 03:01 CLAassistant

@17862923747 Hi, thank you very much for your help! Could you please sign the CLA so we can accept your contribution? This PR will be reviewed asap.

ly015 avatar Jan 16 '23 02:01 ly015

@17862923747 您好,请问您还有更新这个 PR 的计划吗?如果有任何困难,我们也可以帮助您一起完善这个 PR 的内容

Ben-Louis avatar Mar 08 '23 05:03 Ben-Louis

Hi @17862923747 !We are grateful for your efforts in helping improve this open-source project during your personal time.

Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

OpenMMLab-Assistant001 avatar Apr 13 '23 04:04 OpenMMLab-Assistant001