mmocr icon indicating copy to clipboard operation
mmocr copied to clipboard

Updated the det.md Chinese translation

Open EugeneWong2002 opened this issue 2 years ago • 5 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Helping with the translation to contribute and so people who only read Chinese can also read the documentation.

Modification

Updated Chinese translation to the current English version.

Checklist

Before PR:

  • [ x] I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • [ ] Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • [ ] Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • [ ] New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • [ ] The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • [ ] If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • [ ] CLA has been signed and all committers have signed the CLA in this PR.

EugeneWong2002 avatar Apr 26 '22 13:04 EugeneWong2002

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 26 '22 13:04 CLAassistant

Hi @EugeneWong2002 Thank you for your contribution, we will review your PR soon.

Mountchicken avatar Apr 26 '22 13:04 Mountchicken

Thank you for your contribution! We will review this PR soon. You may currently read some notes below to help us improve this PR.

  • We have fixed some known issues in PR #955. Could you also update these modifies to the CN docs?
  • You can click the details bottom in the CI status (see the screenshot below as an example) to preview the doc so that some apparent issues can be quickly found here.
  • Could you kindly sign the Contributor License Agreement, so we can accept the contribution!
1650982115(1)

xinke-wang avatar Apr 26 '22 14:04 xinke-wang

Hi @EugeneWong2002 , Thank you for your excellent translations! There are a few issues that need to be resolved before we can merge this PR into the repo:

  • Some datasets used incorrect head level, which will cause an incorrect drop-down list while rendering the doc (see the figure below). image
  • We do not translate a specific dataset name such as Born-digital Images.
  • We always request a blank between Chinese and English words for better viewing. I marked some but not all cases in the comments as an example. You may need to proofread the doc to correct these cases.

Thank you again for your contribution! And if you do not have time to fix the above issues that would be totally fine, just tell us and we will do the rest.

By the way, we ask all contributors to sign the Contributor License Agreement (which show at the top of this PR), so we can accept the contributions. Have a nice day!

xinke-wang avatar Apr 29 '22 02:04 xinke-wang

Hi @EugeneWong2002 !We are grateful for your efforts in helping improve mmocr open-source project during your personal time. Welcome to join OpenMMLab Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA If you have a WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:) Thank you again for your contribution❤

OpenMMLab-Assistant-004 avatar Apr 12 '23 04:04 OpenMMLab-Assistant-004