mmgeneration icon indicating copy to clipboard operation
mmgeneration copied to clipboard

[Fix] wgangp config error

Open zeng-hello-world opened this issue 2 years ago • 5 comments

zeng-hello-world avatar Aug 30 '21 08:08 zeng-hello-world

Codecov Report

Merging #100 (a10deb9) into master (931b3ea) will decrease coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   76.01%   75.98%   -0.03%     
==========================================
  Files         118      118              
  Lines        8092     8092              
  Branches     1520     1520              
==========================================
- Hits         6151     6149       -2     
- Misses       1550     1551       +1     
- Partials      391      392       +1     
Flag Coverage Δ
unittests 75.98% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmgen/datasets/pipelines/crop.py 95.06% <100.00%> (ø)
mmgen/datasets/unconditional_image_dataset.py 88.57% <100.00%> (ø)
mmgen/models/gans/base_gan.py 68.13% <100.00%> (ø)
mmgen/models/gans/singan.py 74.03% <100.00%> (ø)
mmgen/ops/conv2d_gradfix.py 14.95% <100.00%> (ø)
mmgen/models/architectures/stylegan/mspie.py 90.59% <0.00%> (-1.00%) :arrow_down:
...chitectures/stylegan/generator_discriminator_v1.py 89.83% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 931b3ea...a10deb9. Read the comment docs.

codecov-commenter avatar Sep 01 '21 08:09 codecov-commenter

Hi @zeyu-hello, you may use the pre-commit hook by the following commands:

cd mmgen
pip install -U pre-commit
pre-commit install

Then, when you commit changes, the pre-commit hook will automatically check your linting error.

nbei avatar Sep 03 '21 16:09 nbei

@nbei On my PC, all passed:

pre-commit run --all-files
flake8...................................................................Passed
seed isort known_third_party.............................................Passed
isort....................................................................Passed
yapf.....................................................................Passed
Trim Trailing Whitespace.................................................Passed
Check Yaml...............................................................Passed
Fix End of Files.........................................................Passed
Fix requirements.txt.....................................................Passed
Fix double quoted strings................................................Passed
Check for merge conflicts................................................Passed
Fix python encoding pragma...............................................Passed
Mixed line ending........................................................Passed
docformatter.............................................................Passe

zeng-hello-world avatar Sep 09 '21 02:09 zeng-hello-world

Please help to improve this pull request so that it can be merged @plyfager

zengyh1900 avatar Oct 12 '22 08:10 zengyh1900

Thank you for your contribution. I'll further modify this PR and make it merged.

plyfager avatar Oct 13 '22 08:10 plyfager