mmdetection
mmdetection copied to clipboard
open-mmlab
[Doc]: update user guide: "finetune.md, inference.md"
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Update user guide based on English version.
Modification
Update Two user guides were updated based on English version
- docs/zh_cn/user_guides/finetune.md
- docs/zh_cn/user_guides/inference.md Fixed Fixed a misspelling in inference.md
- docs/en/user_guides/finetune.md
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos? If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
- Pre-commit or other linting tools are used to fix the potential lint issues.
- The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
- If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
- The documentation has been modified accordingly, like docstring or example tutorials.
Hi @DanShouzhu ,
Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR?
The details can be found by clicking the item of lint check as shown below
@zytx121 Thanks for your review and suggestions, all changes have been accepted. However, it still did not pass tests, would you mind taking a look again?
Hi @DanShouzhu , Thanks for your kind contribution. Would you like to fix the lint issue so that we could merge this PR? The details can be found by clicking the item of lint check as shown below
Sure, I have already applied the suggested code changes given by @zytx121.
But, it still did not pass the test system, we will continue to deal with it.
seems the lint has failed, please fix the lint
you can follow https://github.com/open-mmlab/mmcv/blob/master/CONTRIBUTING.md
@BIGWangYuDong
All checks have passed after using pre-commit.
Thank you so much!
Hi @DanShouzhu , Is there any progress in this PR?
Hello Wayne,
I made some updates.
Could you do a code review for this PR?
Best Regards, Cecil Dan
Hi @DanShouzhu , The overall PR LGTM now and can be merged after fixing these small issues
Hi @DanShouzhu please also add Objects365 in English documents. Thx!
Thanks for your reminder, Objects365 has been added.
Hi @DanShouzhu ！First of all, we want to express our gratitude for your significant PR in the MMDet project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us ：https://discord.gg/UjgXkPWNqA
If you have WeChat account，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends：） Thank you again for your contribution！❤
