mmdetection icon indicating copy to clipboard operation
mmdetection copied to clipboard

Modify some typehints in csp_darknet.py

Open hjy94wo777 opened this issue 2 years ago • 2 comments

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Modify some typehints in csp_darknet.py.

Modification

Modify some typehints in csp_darknet.py.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

hjy94wo777 avatar Nov 28 '22 08:11 hjy94wo777

Sorry, I'm not sure how to write the doc string in the forward function

hjy94wo777 avatar Nov 28 '22 08:11 hjy94wo777

Sorry, I'm not sure how to write the doc string in the forward function

You can have a look at other models. A simple example here:

"""Forward function.

Args: xxx

Returns: Tensor: """

BIGWangYuDong avatar Nov 29 '22 02:11 BIGWangYuDong

Is there any progress?

ZwwWayne avatar Jan 29 '23 11:01 ZwwWayne

Closed as it cannot be merged in to dev-3.x.

ZwwWayne avatar Feb 27 '23 08:02 ZwwWayne